bug in ipam_backend_mixin delete_port

[Aaron Rosen]

It's possible for a port to be deleted concurrently in which case here:

https://github.com/openstack/neutron/blob/master/neutron/db/ipam_backend_mixin.py#L417

None will be passed to context.session.delete() This results in this error being raised:

http://logs.openstack.org/25/224225/2/check/gate-tempest-dsvm-networking-ovn/8719aa6/logs/screen-q-svc.txt.gz?level=TRACE#_2015-09-16_18_38_59_368

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/224289

[Armando Migliaccio (armando-migliaccio)]

http://logstash.openstack.org/#eyJzZWFyY2giOiJtZXNzYWdlOlwiVW5tYXBwZWRJbnN0YW5jZUVycm9yOiBDbGFzcyAnX19idWlsdGluX18uTm9uZVR5cGUnIGlzIG5vdCBtYXBwZWRcIiIsImZpZWxkcyI6W10sIm9mZnNldCI6MCwidGltZWZyYW1lIjoiNjA0ODAwIiwiZ3JhcGhtb2RlIjoiY291bnQiLCJ0aW1lIjp7InVzZXJfaW50ZXJ2YWwiOjB9LCJzdGFtcCI6MTQ0MjQzNjI4MzM0NX0=

message:"UnmappedInstanceError: Class '__builtin__.NoneType' is not mapped"

194 hits in 7 days. OVN job the most offender.

[Armando Migliaccio (armando-migliaccio)]

On closer inspection this looks like to be mostly exercised by the way OVN works

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/224337

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/224289
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=77de4a3b54110c2d5b8b38efdfbeb5c35e2cb16d
Submitter: Jenkins
Branch: master

commit 77de4a3b54110c2d5b8b38efdfbeb5c35e2cb16d
Author: Aaron Rosen <email address hidden>
Date: Wed Sep 16 15:50:21 2015 -0700

    ipam: Prevent none from being passed to delete

    Previously, it was possible for None to be passed to context.session.delete()
    if a port was not found (usually a result of a concurrent delete). This
    resulted in an UnmappedInstanceError. This is avoided now by calling
    query.delete() directly which does not raise any exceptions.

    Change-Id: I3b9f513308d90874ac8e8a7f6345697978d4920f
    Closes-bug: #1496554

[OpenStack Infra (hudson-openstack)]

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: master
Review: https://review.openstack.org/224337
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.