custom DictMatches matcher in unit tests can be removed

Bug #1496552 reported by Pavlo Shchelokovskyy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Wishlist
Pavlo Shchelokovskyy

Bug Description

Ironic only supports py27, and on py27 the assertEqual handles nested dicts comparison just fine

if one does not use the assertEqual (that is overriden from unittest[2] by testtools) but assertDictEqual (coming from parent classes directly), you even get a nice output highlighting where is the difference between dicts

this custom matcher is used in only one test module, and assertDictEqual handles those cases currently using DictMatches just fine.

Changed in ironic:
assignee: nobody → Pavlo Shchelokovskyy (pshchelo)
Revision history for this message
Ruby Loo (rloo) wrote :

Although not officially, ironic will need to support py3.4 too.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/224287

Changed in ironic:
status: New → In Progress
Dmitry Tantsur (divius)
Changed in ironic:
importance: Undecided → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/224287
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=9670d2bd26a6228f6150f4698b2c55b4348af395
Submitter: Jenkins
Branch: master

commit 9670d2bd26a6228f6150f4698b2c55b4348af395
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Wed Sep 16 22:58:04 2015 +0300

    Remove DictMatches custom matcher from unit tests

    On Py27 assertDictEqual handles nested dictionaries just fine.

    Change-Id: I0695a1249a3c4153ba4cc49405640a3e09a2af04
    Closes-Bug: #1496552

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
milestone: none → 4.2.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.