custom DictMatches matcher in unit tests can be removed
Bug #1496552 reported by
Pavlo Shchelokovskyy
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ironic |
Fix Released
|
Wishlist
|
Pavlo Shchelokovskyy |
Bug Description
Ironic only supports py27, and on py27 the assertEqual handles nested dicts comparison just fine
if one does not use the assertEqual (that is overriden from unittest[2] by testtools) but assertDictEqual (coming from parent classes directly), you even get a nice output highlighting where is the difference between dicts
this custom matcher is used in only one test module, and assertDictEqual handles those cases currently using DictMatches just fine.
Changed in ironic: | |
assignee: | nobody → Pavlo Shchelokovskyy (pshchelo) |
Changed in ironic: | |
importance: | Undecided → Wishlist |
Changed in ironic: | |
milestone: | none → 4.2.0 |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Although not officially, ironic will need to support py3.4 too.