Invalid deletion policy not correctly validated

[Steven Hardy]

$ heat stack-create del1 -f del_pol.yaml
ERROR:

-bash-4.3$ cat del_pol.yaml
heat_template_version: 2013-05-23
resources:
  test:
    type: OS::Heat::RandomString
    deletion_policy: wibble

This is because we're failing to catch an AssertionError in the engine when creating the ResourceDefinition in stack.Stack.validate (we catch it, but in the wrong place).

[Zane Bitter (zaneb)]

We should explicitly convert the policy values that are valid in the template to the values that are valid in the ResourceDefinition API, instead of relying on programming-by-coincidence for them to be the same. We should never ever ever catch an AssertionError.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/224292

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/224292
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=92bf3aa5dcf04d6d653174d3497de00a8b5c518b
Submitter: Jenkins
Branch: master

commit 92bf3aa5dcf04d6d653174d3497de00a8b5c518b
Author: Steven Hardy <email address hidden>
Date: Wed Sep 16 21:38:47 2015 +0100

    Validate deletion policy during template parsing

    Currently we pass the template value directly into ResourceDefinition
    which can result in an assertion error from the constructor in the
    stack.Stack.validate path. We can avoid this by explicitly translating
    the expected policies for each template dialect into the keys
    supported by the resource definition.

    Change-Id: I54de89ec6b7cd4af722c9c263577252c15aaad64
    Closes-Bug: #1496502