Some Nailgun tests fail with different PYTHONHASHSEED

Bug #1496448 reported by Ihor Kalnytskyi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Ihor Kalnytskyi
7.0.x
Won't Fix
Undecided
Unassigned

Bug Description

Some tests in Nailgun is failing on different PYTHONHASHSEED. This is unacceptable situation, because tests shouldn't depend on its value.

Tests that fail:

- TestNeutronNetworkConfigurationValidatorProtocol.test_vlan_range
- TestDeploymentAttributesSerialization70.test_non_default_bridge_mapping
- TestDeploymentAttributesSerializationSegmentationGre70.test_non_default_bridge_mapping
- TestNetworkManager.test_update_networks_meta

Priority is High since randomly failing tests block development process.

Changed in fuel:
milestone: none → 8.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/224205

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/224205
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=2123640a11db81588086f6df1cf343a81c4800f2
Submitter: Jenkins
Branch: master

commit 2123640a11db81588086f6df1cf343a81c4800f2
Author: Igor Kalnitsky <email address hidden>
Date: Wed Sep 16 18:22:09 2015 +0300

    Make Nailgun tests independed from PYTHONHASHSEED

    test_vlan_range
      The test has been failing because JSON schema validates restriction in
      order that depends on PYTHOHASHSEED. So the fix is to use proper
      values with only one incorrect value.

    test_non_default_bridge_mapping
      The test has been failing because we have a suffix generation for
      bridges implemented via counter. We generate a bridge name with a
      suffix iterating over networks, and PYTHONHASHSEED affects order of
      iteration. So the fix is to do not test bridge names strictly, but
      just most important limits.

    test_update_networks_meta
      The test has been failing because dictionarie's .update() method do
      not perform recursive update, and removes some needed keys
      (such as 'name') so next network lookup may fail.

    TestDeleteIBPImagesTask
      The test has been failing because CMD line has files to remove, and
      their order depend on PYTHONHASHSEED (since they are extracted as
      .keys() from some dictionary structure). So the fix is to perform
      smart check for the command line, not strict one.

    Closes-Bug: #1496448

    Change-Id: I882bbf53f48c842070cb336b1185c40a3dfacc6b
    Signed-off-by: Igor Kalnitsky <email address hidden>

Changed in fuel:
status: In Progress → Fix Committed
Dmitry Pyzhov (dpyzhov)
tags: added: tech-debt
Dmitry Pyzhov (dpyzhov)
tags: added: area-python
tags: added: on-verification
Revision history for this message
ElenaRossokhina (esolomina) wrote :

Verified on Fuel build
VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  openstack_version: "2015.1.0-8.0"
  api: "1.0"
  build_number: "185"
  build_id: "185"
  fuel-nailgun_sha: "7d7366c2ec9b46e4ac90d9c6d3c9e7b87e40ac14"
  python-fuelclient_sha: "e685d68c1c0d0fa0491a250f07d9c3a8d0f9608c"
  fuel-agent_sha: "6f3026d8c8e0927ee8fdf9d3171d506674cc7130"
  fuel-nailgun-agent_sha: "16f5c1a1575a6b482f5159dd2e4b255c03167a7e"
  astute_sha: "c8400f51b0b92254da206de55ef89d17fdf35393"
  fuel-library_sha: "9e565fa8550c78e6391e1da10c07f8be3d329dec"
  fuel-ostf_sha: "c2e1fa0ca859c163a7ff445a70f1264d6be0893b"
  fuel-createmirror_sha: "994fed9b1ed889718b61a59733275c08c2dd4c64"
  fuelmenu_sha: "d12061b1aee82f81b3d074de74ea27a6e962a686"
  shotgun_sha: "c377d163519f6d10b69a654019d6086ba5f14edc"
  network-checker_sha: "a57e1d69acb5e765eb22cab0251c589cd76f51da"
  fuel-upgrade_sha: "1e894e26d4e1423a9b0d66abd6a79505f4175ff6"
  fuelmain_sha: "cd084cf5c4372a46184fb7c2f24568da4e030be2"
Nailgun tests were launched one-by-one, in group. Several logs attached

tags: removed: on-verification
Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.