Public packages are not displayed on `package definitions` tab for non-admin users with `manage_public_package` perms

Bug #1496418 reported by Kirill Zaitsev
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Murano
Fix Released
High
Ekaterina Chernova

Bug Description

Steps for reproduce:
* Login to Horizon as an admin user
* Upload murano package
* Make the package public
* Create new non-admin user with permissions to edit public murano packages `manage_public_packages` (edit policy.json if necessary)
* Login to Horizon as new user
* Navigate to Murano -> Manage -> Package Definitions tab

Actual result:
User doesn't see public packages

Expected result:
User can see public packages

https://bugs.launchpad.net/mos/+bug/1496355

tags: added: api dashboard policy
affects: mos → murano
Changed in murano:
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Ekaterina Chernova (efedorova)
milestone: none → liberty-rc1
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (master)

Fix proposed to branch: master
Review: https://review.openstack.org/224180

Changed in murano:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to murano-dashboard (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/224194

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to murano-dashboard (master)

Reviewed: https://review.openstack.org/224194
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=161f016a35bbf3d2686c7515c75c0e4e022cce2d
Submitter: Jenkins
Branch: master

commit 161f016a35bbf3d2686c7515c75c0e4e022cce2d
Author: Ekaterina Chernova <email address hidden>
Date: Wed Sep 16 19:46:47 2015 +0300

    Show 'Tenant name' column for non-admin users

    To identify own packages and foreign (public) packages,
    column with tenant teme is provided.
    It is shown for admin, and now enabled for non-admin.

    Since non-admin have no rights to identify tenant by id,
    'other' is used instead for non-user tenant.

    Change-Id: I482b89d6659297d8dd3dc5c7882408278b471220
    Related-Bug: 1496418

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to murano-dashboard (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/224784

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (master)

Reviewed: https://review.openstack.org/224180
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=d193bf7f4ef793780d08922be2de5dd4d56b426b
Submitter: Jenkins
Branch: master

commit d193bf7f4ef793780d08922be2de5dd4d56b426b
Author: Ekaterina Chernova <email address hidden>
Date: Wed Sep 16 19:14:10 2015 +0300

    Show public packages for non-admin users

    But only if modification of public packages are allowed in policy file.
    Turn off managing public packagef for non-admin users by default.

    Currently non-admin users are able to see only their own packages
    despite of the policy setting.

    Corresponding tests were updated.

    Change-Id: I5510f6b8b82d7d28358e1b7dcbffe275079512ee
    Closes-Bug: #1496418

Changed in murano:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to murano-dashboard (master)

Reviewed: https://review.openstack.org/224784
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=071c61f3b2e7cbec30c64f6b61be59008fab7a2a
Submitter: Jenkins
Branch: master

commit 071c61f3b2e7cbec30c64f6b61be59008fab7a2a
Author: Kirill Zaitsev <email address hidden>
Date: Thu Sep 17 18:09:23 2015 +0300

    Prevent UnboudLocalError when checking out tenants for packages

    Before an UnboudLocalError would be thrown in case keystone returned an
    error, when asking for tenant list on 'Package Definitions' tab.
    This patch initialises the variable, to prevent such errors.

    Change-Id: I2ee359959907a4d67baa26fbc37d71f6477dfb35
    Related-Bug: 1496418

Changed in murano:
status: Fix Committed → Fix Released
Changed in murano:
status: Fix Released → Fix Committed
Changed in murano:
status: Fix Committed → Fix Released
Changed in murano:
milestone: liberty-rc1 → 1.0.0
Changed in murano:
milestone: 1.0.0 → 1.0.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.