Murano should automatically convert script line-endings for the target guest OS

[Pradip Rawat]

Murano packages are often developed in envoronment other than used for deployment. For example it is often that Linux shell scripts get edited using Windows editor. As a result scripts have Windows line-endings and such scripts fail to work on Linux with confusing error messages (like file not found when it is).

This can be avoided if Murano use universal line-endings for text-mode files (those that are not enclosed in triangle brackets in
execution plan templates).

[Kirill Zaitsev (kzaitsev)]

2 months, no progress. Removing assignee and in-progress mention. ANyway you shouldn't set in-progress by hand.

[Ravi Shekhar Jethani (ravishekar-jethani)]

Application scripts that are run by murano-agent are an outside entity to murano so IMO murano should not be responsible for fixing problems in appliction scripts.

Also there can be thousands of such scripts executed directly or indirectly by murano-agent. Checking each and every file doesn't sound practical.

[Kirill Zaitsev (kzaitsev)]

Ravi Shekhar Jethani, are you still working on this one?

[Kirill Zaitsev (kzaitsev)]

Looks like there is still no progress here, removing assignee

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/311104

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/316771

[OpenStack Infra (hudson-openstack)]

Change abandoned by Valerii Kovalchuk (<email address hidden>) on branch: master
Review: https://review.openstack.org/311104
Reason: Made a solution on the agent side https://review.openstack.org/#/c/316771/

[OpenStack Infra (hudson-openstack)]

Change abandoned by Valerii Kovalchuk (<email address hidden>) on branch: master
Review: https://review.openstack.org/316771

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/311104
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=9d0c88a47bf871c5f5698aa77c9433a4bf1baa31
Submitter: Jenkins
Branch: master

commit 9d0c88a47bf871c5f5698aa77c9433a4bf1baa31
Author: Valerii Kovalchuk <email address hidden>
Date: Fri Apr 29 15:52:31 2016 +0300

    Convert script line endings for the target OS

    This patch adds 'binary' parameter to ResourceManager 'string'
    method. It allows to open text files in 'rU' mode which recognizes
    all types of newlines, and binary files in 'rb' mode to prevent
    their corruption.

    Change-Id: I505070df187dfd910e68c555319e3ef92ce2c826
    Closes-bug: #1496376

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/murano 3.0.0.0b2 development milestone.