Tempest test_pool_list_(detail_)with_filters should be more explicit

Bug #1496375 reported by Clinton Knight
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Low
Clinton Knight

Bug Description

The tests in manila that deal with listing pools with filters applied are sending a pool name as part of the filters, which is treated as a regex by the scheduler. But the tests do not use ^ and $ in the regex's, so if a backend has similarly named pools (i.e. aggr0 and aggr0_node1) then the test could match too many items and report a false failure. We encountered this issue in our CI system.

Tags: tempest
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/224890

Changed in manila:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/224890
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=e61b76c5bfc0f0a9dce3f3db80691c65638d12eb
Submitter: Jenkins
Branch: master

commit e61b76c5bfc0f0a9dce3f3db80691c65638d12eb
Author: Clinton Knight <email address hidden>
Date: Wed Sep 16 08:25:03 2015 -0400

    Fix pool_list filter tests to match pools exactly

    The Tempest tests for the scheduler's pool-list filters can match pools
    other than the ones they should, because the regex strings are not
    wrapped with ^ and $. We hit this in the NetApp CI system.

    Closes-Bug: #1496375
    Change-Id: I423ea164ff62df87e31e5b0ed5cf19870e897cde

Changed in manila:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in manila:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in manila:
milestone: liberty-rc1 → 1.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.