Glanceclient downloads image before deleting it

Bug #1496305 reported by Flavio Percoco
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance Client
Fix Released
Low
Flavio Percoco
Kilo
Fix Committed
Low
Flavio Percoco
Liberty
Fix Committed
Low
Flavio Percoco

Bug Description

Glanceclient downloads the image data before deleting it to check whether its status is deleted... This logic belongs to the server and the client shouldn't make any assumptions about it.

Changed in python-glanceclient:
importance: Undecided → Low
assignee: nobody → Flavio Percoco (flaper87)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-glanceclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/223973

Changed in python-glanceclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-glanceclient (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/225068

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-glanceclient (master)

Reviewed: https://review.openstack.org/223973
Committed: https://git.openstack.org/cgit/openstack/python-glanceclient/commit/?id=b8a881f5ea89514d715e61b632bc3081a0dde2c6
Submitter: Jenkins
Branch: master

commit b8a881f5ea89514d715e61b632bc3081a0dde2c6
Author: Flavio Percoco <email address hidden>
Date: Wed Sep 16 10:56:31 2015 +0200

    Don't get the image before deleting it

    The client currently downloads the image metadata to check if it's deleted
    or not. This logic belongs to the server and it's already implemented
    there. Instead of getting the image, send the delete request and catch
    the 404 error, which is already raised by the server.

    Change-Id: I1e6ef42340f8e380ff99b9d6ca7ea416e0eebfbc
    Closes-bug: #1496305

Changed in python-glanceclient:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-glanceclient (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/226636

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-glanceclient (stable/liberty)

Reviewed: https://review.openstack.org/226636
Committed: https://git.openstack.org/cgit/openstack/python-glanceclient/commit/?id=e82d9df74cbac9accc8a6724c0759760e44bb315
Submitter: Jenkins
Branch: stable/liberty

commit e82d9df74cbac9accc8a6724c0759760e44bb315
Author: Flavio Percoco <email address hidden>
Date: Wed Sep 16 10:56:31 2015 +0200

    Don't get the image before deleting it

    The client currently downloads the image metadata to check if it's deleted
    or not. This logic belongs to the server and it's already implemented
    there. Instead of getting the image, send the delete request and catch
    the 404 error, which is already raised by the server.

    Change-Id: I1e6ef42340f8e380ff99b9d6ca7ea416e0eebfbc
    Closes-bug: #1496305
    (cherry picked from commit b8a881f5ea89514d715e61b632bc3081a0dde2c6)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-glanceclient (stable/kilo)

Reviewed: https://review.openstack.org/225068
Committed: https://git.openstack.org/cgit/openstack/python-glanceclient/commit/?id=68cf63da7a53a88f0b977bf9f9ce875a51ecb407
Submitter: Jenkins
Branch: stable/kilo

commit 68cf63da7a53a88f0b977bf9f9ce875a51ecb407
Author: Flavio Percoco <email address hidden>
Date: Wed Sep 16 10:56:31 2015 +0200

    Don't get the image before deleting it

    The client currently downloads the image metadata to check if it's deleted
    or not. This logic belongs to the server and it's already implemented
    there. Instead of getting the image, send the delete request and catch
    the 404 error, which is already raised by the server.

    Change-Id: I1e6ef42340f8e380ff99b9d6ca7ea416e0eebfbc
    Closes-bug: #1496305
    (cherry picked from commit b8a881f5ea89514d715e61b632bc3081a0dde2c6)
    (cherry picked from commit e82d9df74cbac9accc8a6724c0759760e44bb315)

Changed in python-glanceclient:
milestone: none → 1.2.0
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-glanceclient 0.17.3

This issue was fixed in the openstack/python-glanceclient 0.17.3 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-glanceclient 1.1.1

This issue was fixed in the openstack/python-glanceclient 1.1.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.