[nailgun] Bonding conf is inconsistent after cloud ops

[Michael Polenchuk]

Description of the environment:
env {
  release: "7.0"
  openstack_version: "2015.1.0-7.0"
  build_number: "292"
}

network with vlan {
  bond0 { eth0, eth1 } consists of { admin/pxe }
  bond1 { eth2, eth3, eth4, eth5 } consists of {public, storage, mgmt, private}
}

Steps to reproduce:
* start deploy
* emulate error on node by interrupting the process (e.g. "killall puppet")

Expected result:
network configuration is the same as initially before deployment

Actual result:
nailgun has only two interfaces of six in "node_nic_interfaces" table.
The root cauze is that all interfaces in bond node have the same mac-addresses.

Solution:
* Block network update in nailgun for Error node state.
* Handle the identical mac-address for interfaces.
* Substitute changed mac of interface with the original one in nailgun-agent:
    # macchanger -s eth5
    Current MAC: 64:e0:04:1c:14:03 (unknown)
    Permanent MAC: 64:53:0a:49:e6:95 (unknown)

Impact:
The initial network configuration is messed up and lead to inconsistent behaviour.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/223991

[Dmitry Klenov (dklenov)]

We would need to port the fix to 7.0

[Michael Polenchuk (mpolenchuk)]

Debug process is in progress

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/223991
Committed: https://git.openstack.org/cgit/openstack/fuel-nailgun-agent/commit/?id=e623c89f94911c5bc70eb73abf77921c7a5e246c
Submitter: Jenkins
Branch: master

commit e623c89f94911c5bc70eb73abf77921c7a5e246c
Author: Michael Polenchuk <email address hidden>
Date: Wed Sep 16 12:40:15 2015 +0300

    Return original interface mac

    In order to prevent nailgun get inconsistent network configuration in
    case of interface bonding mode return original mac address.

    Change-Id: Ib0a5c86484d86bf07098a51de87baae931db66ec
    Closes-Bug: #1496279

[Michael Polenchuk (mpolenchuk)]

+ fixed tests: https://bugs.launchpad.net/fuel/+bug/1508986

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/7.0
Review: https://review.openstack.org/238883

[Ksenia Svechnikova (kdemina)]

Verify the fix at MOS 8.0 https://paste.mirantis.net/show/1331/

Steps to reproduce:
* Start deploy
* Emulate error on node by interrupting the process (e.g. "killall puppet")
* Check the bonds on the nodes after it get error state with /proc/net/bond*
* Reset env, check the interface configuraion of the env

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/238883
Committed: https://git.openstack.org/cgit/openstack/fuel-nailgun-agent/commit/?id=d6756e467dc79d08e0be75d41951bed943ac8887
Submitter: Jenkins
Branch: stable/7.0

commit d6756e467dc79d08e0be75d41951bed943ac8887
Author: Michael Polenchuk <email address hidden>
Date: Wed Sep 16 12:40:15 2015 +0300

    Return original interface mac

    In order to prevent nailgun get inconsistent network configuration in
    case of interface bonding mode return original mac address.

    Change-Id: Ib0a5c86484d86bf07098a51de87baae931db66ec
    Closes-Bug: #1496279
    (cherry picked from commit e623c89f94911c5bc70eb73abf77921c7a5e246c)

[Ksenia Svechnikova (kdemina)]

Verified 7.0-mu-1

[Nastya Urlapova (aurlapova)]

Moved to Fix Released according to a comment above.