In Monasca document, some of the unit expression in the semantics for metrics are not consistent or missing

Bug #1496276 reported by Haruki Yamanashi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Monasca
Fix Committed
Undecided
Haruki Yamanashi

Bug Description

In Monasca document, the unit expression in the metrics semantics is not consistent.

Currently, the expression "Kilobytes" and "Kbytes" are used. These expressions shold be unified to "Kbytes".
"Megabyte" and "megabytes" are also used. These expressions shold be unified to "Mbytes".

And also, for some metrics, unit descriptions are missing. These should be fixed.

Corresponding metrics and proposal are in the below.

A) Process Checks
 - process.io.read_kbytes (Kilobytes => Kbytes)
 - process.io.write_kbytes (Kilobytes => Kbytes)
 - process.mem.real_mbytes (in megabytes => in Mbytes)
 - process.mem.rss_mbytes (in megabytes => in Mbytes)
 - process.mem.vsz_mbytes (in megabytes => in Mbytes)

Corresponding part of the document is the below.
https://github.com/stackforge/monasca-agent/blob/master/docs/Plugins.md#process-checks

B) System Checks
 - mem.free_mb (Megabytes => Mbytes)
 - mem.swap_free_mb (Megabytes => Mbytes)
 - mem.swap_total_mb (Megabytes => Mbytes)
 - mem.swap_used_mb (Megabytes => Mbytes)
 - mem.total_mb (megabytes => Mbytes)
 - mem.usable_mb (megabytes => Mbytes)

 - disk.total_space_mb (disk space => disk space in Mbytes)
 - disk.total_used_space_mb (disk space => disk space in Mbytes)
 - mem.used_buffers (Number of buffers => Number of buffers in Mbytes)
 - mem.used_cached (Memory => Mbytes of memory)
 - mem.used_shared (Memory => Mbytes of memory)

 - monasca.emit_time_sec (Amount of time => Amount of time in seconds)
 - monasca.collection_time_sec (Amount of time => Amount of time in seconds)

Corresponding part of the document is the below.
https://github.com/stackforge/monasca-agent/blob/master/docs/Plugins.md#system-metrics

C) Http Endpoint Checks
 - http_response_time (The response time => The response time in seconds)

Corresponding part of the document is the below.
https://github.com/stackforge/monasca-agent/blob/master/docs/Plugins.md#http-endpoint-checks

Revision history for this message
Allan G (greental) wrote :

agreed it's a problem, will you be able to fix this ?

Changed in monasca:
status: New → Triaged
Changed in monasca:
assignee: nobody → Haruki Yamanashi (h-yamanashi)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to monasca-agent (master)

Fix proposed to branch: master
Review: https://review.openstack.org/225032

Changed in monasca:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to monasca-agent (master)

Reviewed: https://review.openstack.org/225032
Committed: https://git.openstack.org/cgit/stackforge/monasca-agent/commit/?id=91381bfe83b825e03e6dab12cbd407175efa4acc
Submitter: Jenkins
Branch: master

commit 91381bfe83b825e03e6dab12cbd407175efa4acc
Author: Haruki Yamanashi <email address hidden>
Date: Fri Sep 18 15:51:37 2015 +0900

    Unify unit expression for Monasca description

    Some of the unit expression in the semantics for metrics are unified.

    Change-Id: I9a598b24925d540384cfa52d23c8f123e7874007
    Closes-Bug: #1496276

Changed in monasca:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.