String formatting wrong in nova/api/metadata/vendordata_json.py

Bug #1496273 reported by Andreas Jaeger
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Andreas Jaeger

Bug Description

The string contains a missing "s" for "%(variable)s" - and the missing spaces confuse users.

See http://lists.openstack.org/pipermail/openstack-i18n/2015-September/001359.html for the initial report.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/223955

Changed in nova:
assignee: nobody → Andreas Jaeger (jaegerandi)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/223955
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1fa0afb8341fd31b8b0cb166503698eaca0715ee
Submitter: Jenkins
Branch: master

commit 1fa0afb8341fd31b8b0cb166503698eaca0715ee
Author: Andreas Jaeger <email address hidden>
Date: Wed Sep 16 09:50:41 2015 +0200

    Fix string formatting in api/metadata/vendordata_json.py

    The string format should be "%(logprefix)s", add the missing "s" in one
    case.

    The strings currently do not include a space after the "s" which
    confuses translators. Add the space and remove it from logprefix.

    Change-Id: I6b3113e184c9c3cee1e2ebe448655c7488efb61b
    Closes-Bug: #1496273

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → liberty-rc1
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to nova (master)

Reviewed: https://review.openstack.org/224009
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=16a50ea03dc1c673435d6d46c15f22dbdb5b70a8
Submitter: Jenkins
Branch: master

commit 16a50ea03dc1c673435d6d46c15f22dbdb5b70a8
Author: Davanum Srinivas <email address hidden>
Date: Wed Sep 16 06:10:59 2015 -0400

    Slightly better translation friendly formatting

    Found these inspired by the email thread and bug filed by
    the translation team.

    Related-Bug: #1496273
    Change-Id: Icc8f341c57cd0e0eb14136d239f51c9699ef6af3

Thierry Carrez (ttx)
Changed in nova:
milestone: liberty-rc1 → 12.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.