[engine] It's not provided on witch property contract is failed

Bug #1496044 reported by Ekaterina Chernova
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
High
Serg Melikyan
Liberty
Fix Released
High
Serg Melikyan
Mitaka
Fix Released
High
Stan Lagun

Bug Description

Take a look at the following error:

http://paste.openstack.org/show/463124/

Error message doesn't indicate on which property contract is failed.

It's very important to add this information to a traceback

Tags: ux
summary: - [engine] Detailed message is not provided on property validation
+ [engine] It's not provided on witch property contract is failed
Changed in murano:
assignee: nobody → Nikolay Starodubtsev (starodubcevna)
Changed in murano:
milestone: next → mitaka-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (master)

Fix proposed to branch: master
Review: https://review.openstack.org/228259

Changed in murano:
assignee: Nikolay Starodubtsev (starodubcevna) → Stan Lagun (slagun)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/228293

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (master)

Reviewed: https://review.openstack.org/228259
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=1d72b9dd6134f020b9a134fd2584631769eefa5c
Submitter: Jenkins
Branch: master

commit 1d72b9dd6134f020b9a134fd2584631769eefa5c
Author: Stan Lagun <email address hidden>
Date: Sun Sep 27 19:23:18 2015 +0300

    Specification of which property/argument violated contract was added

    When some property or argument value violated its contract it was impossible
    to tell which property/argument caused the exception.

    This change adds prefix to ContractViolationException message that tells
    not only which property or argument failed to validate but for composite
    properties also the path within the data.
    For example if we change ApacheHttpServer name property contract from
    $.string() to $.int() we will get

    [io.murano.Environment.applications[0]]
    [io.murano.apps.apache.ApacheHttpServer.name]
    Value 'ApacheHttpServer' violates int() contract

    Also for check() contracts ability to provide custom
    error message was added

    Change-Id: I6953ec84140f4bed3d50aa181244f89682b2b2fb
    Closes-Bug: #1496044

Changed in murano:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (stable/liberty)

Reviewed: https://review.openstack.org/228293
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=8f2be0d8711763100d624b4fb025b7f619bf2252
Submitter: Jenkins
Branch: stable/liberty

commit 8f2be0d8711763100d624b4fb025b7f619bf2252
Author: Stan Lagun <email address hidden>
Date: Sun Sep 27 19:23:18 2015 +0300

    Specification of which property/argument violated contract was added

    When some property or argument value violated its contract it was impossible
    to tell which property/argument caused the exception.

    This change adds prefix to ContractViolationException message that tells
    not only which property or argument failed to validate but for composite
    properties also the path within the data.
    For example if we change ApacheHttpServer name property contract from
    $.string() to $.int() we will get

    [io.murano.Environment.applications[0]]
    [io.murano.apps.apache.ApacheHttpServer.name]
    Value 'ApacheHttpServer' violates int() contract

    Also for check() contracts ability to provide custom
    error message was added

    Change-Id: I6953ec84140f4bed3d50aa181244f89682b2b2fb
    Closes-Bug: #1496044

Changed in murano:
milestone: liberty-rc2 → 1.0.0
Changed in murano:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.