Not all firewall tests mock subprocess.check_call and so call out to the underlying system

Bug #1495907 reported by Sam Betts
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic Inspector
Fix Released
Medium
Sam Betts

Bug Description

On systems without iptables or iptables hidden from the test user this results in:

FileNotFoundError: [Errno 2] No such file or directory: 'iptables'

Sam Betts (sambetts)
Changed in ironic-inspector:
assignee: nobody → Sam Betts (sambetts)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic-inspector (master)

Fix proposed to branch: master
Review: https://review.openstack.org/223503

Changed in ironic-inspector:
status: New → In Progress
Dmitry Tantsur (divius)
Changed in ironic-inspector:
importance: Undecided → Medium
milestone: none → 2.2.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic-inspector (master)

Reviewed: https://review.openstack.org/223503
Committed: https://git.openstack.org/cgit/openstack/ironic-inspector/commit/?id=9d95e05ba0257139d0b979f66a317a28fb2e41bc
Submitter: Jenkins
Branch: master

commit 9d95e05ba0257139d0b979f66a317a28fb2e41bc
Author: Sam Betts <email address hidden>
Date: Tue Sep 15 11:11:58 2015 +0100

    Add mock for check_call to all firewall tests

    On systems where the iptables isn't available to test environment,
    subprocess.check_call fails with a FileNotFoundError, this patch
    ensures that all firewall tests mock check_call so its not calling
    out to the underlying test environment.

    Change-Id: Iad56638a992f922db9de00d9036b5b1ce091a411
    Closes-Bug: #1495907

Changed in ironic-inspector:
status: In Progress → Fix Committed
Dmitry Tantsur (divius)
Changed in ironic-inspector:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.