When running the swift playbooks today I noticed a lot of skipped tasks which didn't look quite right.
I've pasted some of the output here: http://paste.openstack.org/show/462145/ but also will reproduce in-line for posterity (in case paste.o.o is unreachable):
skipping: [storage03] => (item=[{u'policy': {u'default': True, u'index': 0, u'name': u'gold'}}, u'g']) [226/1788]
skipping: [infra02_swift_proxy_container-b20bb7b1] => (item=[{u'policy': {u'default': True, u'index': 0, u'name': u'gold'}}, u' '])
skipping: [infra03_swift_proxy_container-7cc37406] => (item=[{u'policy': {u'default': True, u'index': 0, u'name': u'gold'}}, u'a'])
skipping: [infra01_swift_proxy_container-eb05beac] => (item=[{u'policy': {u'default': True, u'index': 0, u'name': u'gold'}}, u'a'])
skipping: [storage03] => (item=[{u'policy': {u'default': True, u'index': 0, u'name': u'gold'}}, u'i'])
skipping: [infra02_swift_proxy_container-b20bb7b1] => (item=[{u'policy': {u'default': True, u'index': 0, u'name': u'gold'}}, u'}'])
skipping: [storage03] => (item=[{u'policy': {u'default': True, u'index': 0, u'name': u'gold'}}, u'o'])
skipping: [infra03_swift_proxy_container-7cc37406] => (item=[{u'policy': {u'default': True, u'index': 0, u'name': u'gold'}}, u'g'])
skipping: [infra01_swift_proxy_container-eb05beac] => (item=[{u'policy': {u'default': True, u'index': 0, u'name': u'gold'}}, u'g'])
skipping: [infra02_swift_proxy_container-b20bb7b1] => (item=[{u'policy': {u'default': True, u'index': 0, u'name': u'gold'}}, u'}'])
skipping: [storage03] => (item=[{u'policy': {u'default': True, u'index': 0, u'name': u'gold'}}, u'n'])
skipping: [infra02_swift_proxy_container-b20bb7b1] => (item=[{u'policy': {u'index': 1, u'repl_number': 3, u'depreciated': True, u'name': u'silver'}}, u'{'])
skipping: [infra03_swift_proxy_container-7cc37406] => (item=[{u'policy': {u'default': True, u'index': 0, u'name': u'gold'}}, u'e'])
skipping: [infra01_swift_proxy_container-eb05beac] => (item=[{u'policy': {u'default': True, u'index': 0, u'name': u'gold'}}, u'e'])
skipping: [storage03] => (item=[{u'policy': {u'default': True, u'index': 0, u'name': u'gold'}}, u's'])
skipping: [infra02_swift_proxy_container-b20bb7b1] => (item=[{u'policy': {u'index': 1, u'repl_number': 3, u'depreciated': True, u'name': u'silver'}}, u'{'])
skipping: [infra02_swift_proxy_container-b20bb7b1] => (item=[{u'policy': {u'index': 1, u'repl_number': 3, u'depreciated': True, u'name': u'silver'}}, u' '])
skipping: [storage03] => (item=[{u'policy': {u'default': True, u'index': 0, u'name': u'gold'}}, u' '])
skipping: [infra03_swift_proxy_container-7cc37406] => (item=[{u'policy': {u'default': True, u'index': 0, u'name': u'gold'}}, u'd'])
skipping: [infra01_swift_proxy_container-eb05beac] => (item=[{u'policy': {u'default': True, u'index': 0, u'name': u'gold'}}, u'd'])
skipping: [infra02_swift_proxy_container-b20bb7b1] => (item=[{u'policy': {u'index': 1, u'repl_number': 3, u'depreciated': True, u'name': u'silver'}}, u's'])
skipping: [storage03] => (item=[{u'policy': {u'default': True, u'index': 0, u'name': u'gold'}}, u'}'])
skipping: [infra02_swift_proxy_container-b20bb7b1] => (item=[{u'policy': {u'index': 1, u'repl_number': 3, u'depreciated': True, u'name': u'silver'}}, u'w'])
skipping: [infra03_swift_proxy_container-7cc37406] => (item=[{u'policy': {u'default': True, u'index': 0, u'name': u'gold'}}, u'_'])
skipping: [infra01_swift_proxy_container-eb05beac] => (item=[{u'policy': {u'default': True, u'index': 0, u'name': u'gold'}}, u'_'])
skipping: [storage03] => (item=[{u'policy': {u'default': True, u'index': 0, u'name': u'gold'}}, u'}'])
skipping: [infra02_swift_proxy_container-b20bb7b1] => (item=[{u'policy': {u'index': 1, u'repl_number': 3, u'depreciated': True, u'name': u'silver'}}, u'i'])
skipping: [storage03] => (item=[{u'policy': {u'index': 1, u'repl_number': 3, u'depreciated': True, u'name': u'silver'}}, u'{'])
skipping: [infra01_swift_proxy_container-eb05beac] => (item=[{u'policy': {u'default': True, u'index': 0, u'name': u'gold'}}, u'r'])
skipping: [infra03_swift_proxy_container-7cc37406] => (item=[{u'policy': {u'default': True, u'index': 0, u'name': u'gold'}}, u'r'])
skipping: [infra02_swift_proxy_container-b20bb7b1] => (item=[{u'policy': {u'index': 1, u'repl_number': 3, u'depreciated': True, u'name': u'silver'}}, u'f'])
skipping: [infra02_swift_proxy_container-b20bb7b1] => (item=[{u'policy': {u'index': 1, u'repl_number': 3, u'depreciated': True, u'name': u'silver'}}, u't'])
skipping: [storage03] => (item=[{u'policy': {u'index': 1, u'repl_number': 3, u'depreciated': True, u'name': u'silver'}}, u'{'])
skipping: [infra01_swift_proxy_container-eb05beac] => (item=[{u'policy': {u'default': True, u'index': 0, u'name': u'gold'}}, u'e'])
skipping: [infra03_swift_proxy_container-7cc37406] => (item=[{u'policy': {u'default': True, u'index': 0, u'name': u'gold'}}, u'e'])
skipping: [infra02_swift_proxy_container-b20bb7b1] => (item=[{u'policy': {u'index': 1, u'repl_number': 3, u'depreciated': True, u'name': u'silver'}}, u'_'])
skipping: [storage03] => (item=[{u'policy': {u'index': 1, u'repl_number': 3, u'depreciated': True, u'name': u'silver'}}, u' '])
skipping: [infra02_swift_proxy_container-b20bb7b1] => (item=[{u'policy': {u'index': 1, u'repl_number': 3, u'depreciated': True, u'name': u'silver'}}, u'm'])
Note that some of the parameters are single letters, underscores, curly braces, etc. When you inspect the task files (https://git.openstack.org/cgit/openstack/openstack-ansible/tree/playbooks/roles/os_swift_sync/tasks/swift_rings_post_distribution_check.yml#n64) you notice that with_nested is passed an incorrect value and it needs to be rewritten.
This led me to reevaluate the usage of with_items and with_nested and I found some very inconsistent uses of it. Many services use
with_items: servicename_apt_packages
but also
with_items:
- "{{ servicename_pip_packages }}"
When both are lists.
Fix proposed to branch: master
Review: https:/