Solum

refactor-trigger-controller

Bug #1495686 reported by Devdatta Kulkarni
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Solum
Fix Released
Wishlist
Swati Dewan
Solum 2015.1.2 "liberty-3"

Bug Description

The post method of trigger controller (api/controllers/v1/trigger.py) is currently bit complex. The code can be broken down into conceptually meaningful sub-methods to simplify it.

https://github.com/openstack/solum/blob/master/solum/api/controllers/v1/trigger.py

See original description
Tags: solum-api
Devdatta Kulkarni (devdatta-kulkarni)
description: updated
description: updated
description: updated
Adrian Otto (aotto)
Changed in solum:
milestone: none → 2015.1.2
status: New → Triaged
Swati Dewan (swatidewan9)
Changed in solum:
assignee: nobody → Swati Dewan (swatidewan9)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to solum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/238714

Changed in solum:
status: Triaged → In Progress
Devdatta Kulkarni (devdatta-kulkarni)
tags: added: solum-api
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/279895

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on solum (master)

Change abandoned by Swati Dewan (<email address hidden>) on branch: master
Review: https://review.openstack.org/279895

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to solum (master)

Reviewed: https://review.openstack.org/238714
Committed: https://git.openstack.org/cgit/openstack/solum/commit/?id=934f7f76065d1253828a6c461072e7d674ee611d
Submitter: Jenkins
Branch: master

commit 934f7f76065d1253828a6c461072e7d674ee611d
Author: Swati Dewan <email address hidden>
Date: Fri Oct 23 04:18:01 2015 +0530

    Refactor trigger controller

    The post method of trigger controller is currently a bit complex. Breaks
    down the code into conceptually meaningful sub-methods and thus
    simplifies it.

    Change-Id: Id13b5f3a7700c48c4997432ea6c7f58b9de701d9
    Closes-Bug: #1495686

Changed in solum:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/solum 4.1.0

This issue was fixed in the openstack/solum 4.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.