Improve unclear messaging for updates

[Sheena Conant]

From Scott Machtmes:

I just installed MOS 6.1 and observed the following:

After I installed Fuel and logged into the UI, the notifications area has a message ( I've copied the exact formatting here also) :

WARNING: There may be updates available for Fuel.\nYou should update this node with 'yum update'. If there are available\n updates, run 'dockerctl destroy all; bootstrap_admin_node.sh;'\nto repeat bootstrap on Fuel Master with the latest updates.\nFor more information, check out Fuel documentation at:\nhttp://docs.mirantis.com/fuel

This messaging is confusing to the user and links to a location that does not provide any information about the scripts that are mentioned.

Proposed solution:
Change message to the following:

We recommend reviewing and applying Maintenance Updates for this release of Mirantis OpenStack (link: https://docs.mirantis.com/openstack/fuel/fuel-6.1/release-notes.html#maintenance-updates).

Note that the release (above fuel-6.1) should reflect the correct release. For 7.0, which I believe is also affected, this would be fuel-7.0.

When MUs move, this link should point to the new location (Knowledge Base) - likely will be moved during 8.0 timeframe.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/224782

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/6.1
Review: https://review.openstack.org/224788

[Evgeny Konstantinov (evkonstantinov)]

To reiterate and provide new information.

There are two variants of the message:

**Variant 1**:

WARNING: There may be updates available for Fuel.\nYou should update this node with 'yum update'. If there are available\n updates, run 'dockerctl destroy all; bootstrap_admin_node.sh;'\nto repeat bootstrap on Fuel Master with the latest updates.\nFor more information, check out Fuel documentation at:\nhttp://docs.mirantis.com/fuel

Should be changed to:

We recommend reviewing and applying Maintenance Updates \
for this release of Mirantis OpenStack: \
https://docs.mirantis.com/openstack/fuel/fuel-${FUEL_RELEASE}/\
release-notes.html#maintenance-updates

**Variant 2**:

WARNING: There are issues connecting to Fuel update repository.
Please fix your connection and update this node with `yum update`
Then run `dockerctl destroy all; bootstrap_admin_node.sh;`
to repeat bootstrap on Fuel Master with the latest updates.
For more information, check out Fuel documentation at:
http://docs.mirantis.com/fuel

Should be changed to:

There is an issue connecting to the Fuel update repository.
Please fix your connection prior to applying any updates.
Once the connection is fixed,
we recommend reviewing and applying Maintenance Updates \
for this release of Mirantis OpenStack: \
https://docs.mirantis.com/openstack/fuel/fuel-${FUEL_RELEASE}/\
release-notes.html#maintenance-updates

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/7.0
Review: https://review.openstack.org/225280

[Mike Scherbakov (mihgen)]

I'd suggest to bump this bug to Critical priority.
When system asks me to mess up with all containers on Fuel Master node, basically destroy all of them and re-bootstrap everything - it is really bad UX.

I'm all for merging text change to stable/7.0, but let's solve this in a right way in 8.0.

More over, this message appears even though I have connection to Internet over http, but this seems to be another issue I'd need to investigate.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/225440

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/224782
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=007aba9f20e691b8e4401ac53c46e85517a9c33b
Submitter: Jenkins
Branch: master

commit 007aba9f20e691b8e4401ac53c46e85517a9c33b
Author: Alexander Kislitsky <email address hidden>
Date: Thu Sep 17 17:55:20 2015 +0300

    Message about available updates fixed

    This change updates the verbage for repository connectivity and
    maintence updates for the fuel master. It also includes a proper
    documentation link.

    Change-Id: I7da1bde77bfcdad66dc64c160b61964e93990dd3
    Closes-Bug: #1495658
    Co-Authored-By: Alex Schultz <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/225280
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=628bfb1ba8413dc69a83b8514d02ecac8a07a7ca
Submitter: Jenkins
Branch: stable/7.0

commit 628bfb1ba8413dc69a83b8514d02ecac8a07a7ca
Author: Alexander Kislitsky <email address hidden>
Date: Thu Sep 17 17:55:20 2015 +0300

    Message about available updates fixed

    This change updates the verbage for repository connectivity and
    maintence updates for the fuel master. It also includes a proper
    documentation link.

    Change-Id: I7da1bde77bfcdad66dc64c160b61964e93990dd3
    Closes-Bug: #1495658
    Co-Authored-By: Alex Schultz <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/6.1
Review: https://review.openstack.org/225997

[OpenStack Infra (hudson-openstack)]

Change abandoned by Alexander Kislitsky (<email address hidden>) on branch: stable/6.1
Review: https://review.openstack.org/224788
Reason: Proper backport provided at https://review.openstack.org/#/c/225997/

[OpenStack Infra (hudson-openstack)]

Change abandoned by Mike Scherbakov (<email address hidden>) on branch: master
Review: https://review.openstack.org/225440
Reason: Another patch merged fixing this issue

[Alexander Kislitsky (akislitsky)]

Fix for 6.1 provided in https://review.openstack.org/#/c/225997/ and ready to be merged. Moving to maintenance team.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/225997
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=1b0f1a4af6226b2273cd622f4a8734d1e821c8f7
Submitter: Jenkins
Branch: stable/6.1

commit 1b0f1a4af6226b2273cd622f4a8734d1e821c8f7
Author: Alexander Kislitsky <email address hidden>
Date: Thu Sep 17 17:55:20 2015 +0300

    Message about available updates fixed

    Backport to 6.1
    This change updates the verbage for repository connectivity and
    maintence updates for the fuel master. It also includes a proper
    documentation link.

    Change-Id: I7da1bde77bfcdad66dc64c160b61964e93990dd3
    Closes-Bug: #1495658
    Co-Authored-By: Alex Schultz <email address hidden>

[Dmitriy Kruglov (dkruglov)]

Verified on MOS 8.0 Kilo. Not reproduced.

ISO info:
VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  openstack_version: "2015.1.0-8.0"
  api: "1.0"
  build_number: "128"
  build_id: "128"
  fuel-nailgun_sha: "70d8b7e80573728e04ac5478c112850afcfa9802"
  python-fuelclient_sha: "56fbd6bad7f60f0944b3845c2db14d0b8cabd4d3"
  fuel-agent_sha: "e881f0dabd09af4be4f3e22768b02fe76278e20e"
  fuel-nailgun-agent_sha: "d66f188a1832a9c23b04884a14ef00fc5605ec6d"
  astute_sha: "0f753467a3f16e4d46e7e9f1979905fb178e4d5b"
  fuel-library_sha: "e3d2905b9dd2cc7b4d46201ca9816dd320868917"
  fuel-ostf_sha: "41aa5059243cbb25d7a80b97f8e1060a502b99dd"
  fuelmain_sha: "51614465980e5f62a5796779d3f6c3305c1d5739"

[Vitaly Sedelnik (vsedelnik)]

Reassigned to Alexey Khivin to create release notes entry for MOS 6.1 MU 3

[Alexey Khivin (akhivin)]

6.1-update release notes https://review.openstack.org/#/c/234344/

[Denis Meltsaykin (dmeltsaykin)]

We cannot deliver this fix in updates neither in 6.1-mu3 nor in 7.0-mu1. The main problem of the fix itself is that it fixes the behavior of a script that runs at very beginning of the fuel master node installation itself. After the script executes it sends a notify to the fuel and we can see a message in notifies section.

Therefore, I have two concerns:
1) The only way to deliver this message is to build a new ISO and deploy a new Fuel Master node or try to rebootstrap the existing Fuel Master node loosing all data. Neither of these methods are acceptable in a running environment.
2) It's just a message. It makes no sense to include such a change into the Maintenance Updates, as it won't fix any real deployment or provisioning bug, just fancier output.

So I suggest to exclude these CRs from the scopes of 6.1-mu and 7.0-mu.

[Sheena Conant (sheena-conant)]

For some reason I thought this message showed up at intervals other than the very beginning of Fuel Master node installation.

Given that it does not, I agree that it is not worth producing a new ISO to address.