[fuelmenu] attempt to setup disabled interface corrupts settings of eth0

[Kyrylo Romanenko]

1. Enter into Fuelmenu.
2. Proceed to "Network Setup" menu.
3. Select "eth1" interface.
eth0 is enabled end configured by default.
eth1 and eth2 are disabled be default.

4. Fill in fields:

IP address: 10.20.0.3
Netmask: 255.255.255.0
Default Gateway: 10.20.0.1

Do not enable eth1, act like you accidentally forgot this.

5. Press "Apply" button.
Expected to have saved settings for eth1.

Actual results:
- Settings for eth1 are blank.
- Field "Default Gateway" of eth0 also is empty.

Fuel 7.0 ISO 288.
Launched in VirtualBox.

[Matthew Mosesohn (raytrac3r)]

Can you get me the contents of /var/log and /etc/sysconfig/network-scripts on your Fuel Master? I want to see what ended up saved.

Also, if eth1 did actually save, the gateway for eth0 is lost. Here are the conditions that dictate default gateway settings (limited by L23network puppet module):
1 - if no gateway, a static interface configuration with gateway wins
2 - if a gateway is already set, the next static interface configuration with gateway wins, old one is lost
3 - if a gateway is already set, the next dhcp configuration wins
4 - if dhcp is set, the next static config wins, but previously configured dhcp will eventually override this.
We don't have any support for multiple gateways.

[Kyrylo Romanenko (kromanenko)]

Here are /var/log and /etc/sysconfig/network-scripts contents.

[Matthew Mosesohn (raytrac3r)]

I get it now. If eth1 is disabled and you leave it disabled, we should not make any changes. Additionally, if there is a gateway set and it's not associated to that interface we are applying, we should not break the gateway (from another iface) as well.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/227290

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/227290
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=2277efc377f257a7226ebdc4e3f04fd45002f349
Submitter: Jenkins
Branch: master

commit 2277efc377f257a7226ebdc4e3f04fd45002f349
Author: Matthew Mosesohn <email address hidden>
Date: Thu Sep 24 16:14:21 2015 +0300

    Preserve gateway when disabling interface in fuelmenu

    Gateway should be preserved if a network interface
    is being disabled, regardless of input.

    Also moved default interface type to Static instead
    of DHCP to reflect typical user behavior.

    Change-Id: I20842999d4400f1cd56f3b3d856b8d07636f0cc8
    Closes-Bug: #1495535

[Dmitry Belyaninov (dbelyaninov)]

Verified on ISO #521

There is no default interface corruption after applying ip/gateway settings for additional interface.

But, it is very bad idea to discard entered values without any Warning message, on Apply or Check action.
User should know that enabling X was not added and all settings will be missed.

VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  api: "1.0"
  build_number: "521"
  build_id: "521"
  fuel-nailgun_sha: "bae6d0062e0825d81409a04bcb4979302f8c65ea"
  python-fuelclient_sha: "4f234669cfe88a9406f4e438b1e1f74f1ef484a5"
  fuel-agent_sha: "658be72c4b42d3e1436b86ac4567ab914bfb451b"
  fuel-nailgun-agent_sha: "b2bb466fd5bd92da614cdbd819d6999c510ebfb1"
  astute_sha: "b81577a5b7857c4be8748492bae1dec2fa89b446"
  fuel-library_sha: "29829b131ca802830bc5a9a131c83cd0f43f702b"
  fuel-ostf_sha: "7bcddf18020f2d94a553a441ff57dff9632865df"
  fuel-mirror_sha: "c25d8931e30322ecf43246c8a957e376259b685c"
  fuelmenu_sha: "e071216cb214e34b4d861478033425ee6a54a3be"
  shotgun_sha: "63645dea384a37dde5c01d4f8905566978e5d906"
  network-checker_sha: "a43cf96cd9532f10794dce736350bf5bed350e9d"
  fuel-upgrade_sha: "616a7490ec7199f69759e97e42f9b97dfc87e85b"
  fuelmain_sha: "a365f05b903368225da3fea9aa42afc1d50dc9b4"

[Kyrylo Romanenko (kromanenko)]

We have regression of this bug on ISO fuel-9.0-mos-465-2016-06-09_22-51-38
When i altered "IP Address" field and applied changes, then "Default Gateway" address disappeared from it's field.