[fuel-upgrade--system] upgade.sh incorrectly handles upgraders-list

[Bulat Gaifullin]

upgrade.sh always extends the default upgrader-list with user specified arguments.
for example:
if upgrader.sh will be star with next arguments:
"upgrader.sh host-upgrade --password=admin", it starts upgrade process with the following arguments:
"fuel-upgrader.py host-system docker openstack host-system --password-admin"

expected result:
1. upgrader.py will starts only with specified list of upgraders.
2. upgrader.py will check that upgraders list contains duplicates.

[Bulat Gaifullin (bulat.gaifullin)]

I think it would be better to move default upgrader list to fuel-upgrade.py, in this case upgrader.sh will pass command-line arguments to fuel-upgrader.py as is, and it will be only "launcher for fuel-upgrader.py"

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/223518

[OpenStack Infra (hudson-openstack)]

Change abandoned by Bulat Gaifullin (<email address hidden>) on branch: master
Review: https://review.openstack.org/223518

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/223529

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/223671

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/223529
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=4012dca9c4f6bfe14b8ed22392ad3364eeed508a
Submitter: Jenkins
Branch: master

commit 4012dca9c4f6bfe14b8ed22392ad3364eeed508a
Author: Bulat Gaifullin <email address hidden>
Date: Tue Sep 15 13:54:27 2015 +0300

    Check that list of upgraders without duplicates

    The list of upgraders specified via command-line should not have duplicates
    added test for incompatibility check

    Change-Id: I24952a9e64034c3a98adbeae67a3c3a8dd7e1b67
    Partial-Bug: #1495454

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/223671
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=3d53f05a3097abadd777ddc0832eabaa203a4c99
Submitter: Jenkins
Branch: master

commit 3d53f05a3097abadd777ddc0832eabaa203a4c99
Author: bgaifullin <email address hidden>
Date: Tue Sep 15 19:04:01 2015 +0300

    upgrader.sh incorrectly handles cmd args - fixed

    positional arguments are replaced default upgraders list,
    keyword arguments are passed to script as is.

    Change-Id: I5e9a0dcd397f7d1e64476768196289c2aced56e7
    Closes-Bug: #1495454

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/240214

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/240214
Committed: https://git.openstack.org/cgit/openstack/fuel-upgrade/commit/?id=e3231e87b7d310b4ef6d4656b3168fdea35eac2c
Submitter: Jenkins
Branch: master

commit e3231e87b7d310b4ef6d4656b3168fdea35eac2c
Author: Bulat Gaifullin <email address hidden>
Date: Tue Sep 15 13:54:27 2015 +0300

    Check that list of upgraders without duplicates

    The list of upgraders specified via command-line should not have duplicates
    added test for incompatibility check

    Change-Id: I24952a9e64034c3a98adbeae67a3c3a8dd7e1b67
    Partial-Bug: #1495454

[Vladimir Khlyunev (vkhlyunev)]

Upgrading via upgrade.sh is no longer available for 8.0 - fix can not be verified since building upgrade package was disabled. Feel free to reopen it for 9.0 if necessary.