Admin user add DHCP agent failed when the network name is blank

Bug #1495105 reported by qiaomin032
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
qiaomin032

Bug Description

Reproduce the bug:
1, Login as an "Admin" user, then go to the "Admin"=>"System"=>"Networks" page, then create a network and it's name is network1;
2, Edit network and set it's name is blank, and it will display it's ID as name;
3,Click the name link and go forward to the network's detail page ;
4, Click "Add DHCP Agent" button and open a form modal, select a "New DHCP Agent", then click the submit button, there will display the error "this field is required" beside the "Network Name" field.

But the add DHCp agent api support network having no name. So when open the "Add DHCP Agent" form modal, there should display the network's name_or_id.

 Related bug:https://bugs.launchpad.net/horizon/+bug/1492667

Please see the attachment for more detail.

Revision history for this message
qiaomin032 (chen-qiaomin) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/222869

Changed in horizon:
assignee: nobody → qiaomin032 (chen-qiaomin)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/222869
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=88674d0f3d0fb00c782e6bdc99ff67038a2ef490
Submitter: Jenkins
Branch: master

commit 88674d0f3d0fb00c782e6bdc99ff67038a2ef490
Author: chenqiaomin <chen.qiaomin@99cloud.net>
Date: Fri Jul 10 15:25:12 2015 -0400

    Fix "create failed" bug in add DHCP agent form

    When Add DHCP agent for a network that it's name is blank,
    it cast error "This field is required" beside the network
    name field. So there should display the network's name_or_id
    in "Add DHCP Agent" form modal, and this is consistent with
    the "Edit Network". This patch fix the bug.

    Change-Id: I4ad4b1d9907d7aa521ba6da44be8230aa301fcb2
    Closes-Bug: #1495105

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
importance: Undecided → High
milestone: none → liberty-rc1
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: liberty-rc1 → 8.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.