Murano does not cache name-to-id mappings of application packages

Bug #1495001 reported by Alexander Tivelkov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mirantis OpenStack
Won't Fix
Medium
Stan Lagun
7.0.x
Won't Fix
Medium
Stan Lagun

Bug Description

When murano deploys application packages and needs their resources (scripts, files etc), it needs to load them from disk. The contents of that package is usually already there, extracted to the temporary directory during the MuranoPL class load process.

However murano does not maintain a mapping between the package fqn's and the names of the temporary directories (the latter are usually the IDs of the packages in repository), so it has to query Murano-Api to get the ID by fqn each time the resource is requested.

This degrades the performance, but more importantly, it dramatically increases the chance of deployment failure due to access token expiration, as the murano-api needs a valid token to authenticate the request.

Murano needs to maintain a map of loaded packages in its package loader, so subsequent get-id-by-fqn calls do not go to murano-api.

A similar approach (with significantly different implementation though) is already merged in upstream. It should be added to 6.1 as well, especially because it is more vulnerable to access-token expiration issues due to a lack of trust support.

Tags: murano
tags: added: murano
Changed in mos:
status: New → Confirmed
Changed in mos:
assignee: nobody → Serg Melikyan (smelikyan)
assignee: Serg Melikyan (smelikyan) → Stan Lagun (slagun)
Changed in mos:
milestone: 6.1-updates → 8.0
status: Confirmed → New
Changed in mos:
importance: Critical → High
status: New → Confirmed
Changed in mos:
milestone: 8.0 → none
assignee: Stan Lagun (slagun) → nobody
importance: High → Critical
importance: Critical → Undecided
status: Confirmed → New
Changed in mos:
milestone: none → 8.0
assignee: nobody → MOS Murano (mos-murano)
importance: Undecided → High
status: New → Confirmed
Changed in mos:
status: Confirmed → Opinion
Revision history for this message
Ekaterina Chernova (efedorova) wrote :

This bug is not seen on 8.0

no longer affects: mos
Revision history for this message
Ekaterina Chernova (efedorova) wrote :

May be we will not fix this in updates at all since it may be a feature not a but

1) is not backporting, it is a completely different code will that still need to be tested
2) Use all the same as the minimum it is in fact important mainly in k8s, and there is a token in the process is necessary not only for the resources including opportunity to live life without the token is not much help. And since you can turn Kilo trusts and the token will not die
3) If you have a living token this fix will only optimization. Ie It will not make a request once in the API. A bekportirovat optimization without real need - it's bad

Changed in mos:
assignee: nobody → MOS Murano (mos-murano)
milestone: none → 8.0
importance: Undecided → High
status: New → Confirmed
Revision history for this message
Ekaterina Chernova (efedorova) wrote :

DOES NOT APPLY FOR 8.0

Changed in mos:
milestone: 8.0 → none
milestone: none → 6.1-updates
no longer affects: mos/6.1.x
Changed in mos:
assignee: MOS Murano (mos-murano) → Stan Lagun (slagun)
Revision history for this message
Vitaly Sedelnik (vsedelnik) wrote :

This is not High bug as there is no data corruption or failure of a signification feature. Won't Fix for 6.1-updates and 7.0-updates because of Medium importance.

Changed in mos:
status: Confirmed → Won't Fix
importance: High → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.