Network groups can not be modified with Fuel CLI

Bug #1494842 reported by Aleksey Kasatkin
32
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
Medium
Ryan Moe
7.0.x
Fix Released
Medium
Artem Roma

Bug Description

Version: MOS 7.0 (build 257)

Validator for NetworkGroupHandler checks node group id from the request but it is not needed.
Node group should not be required here actually as network group id is enough to determine what network is in focus.

Attempting to modify any attribute results in
"TypeError: object of type 'NoneType' has no len()"

Details: http://pastebin.com/nb7dgHQa

Changed in fuel:
assignee: nobody → Fuel Python Team (fuel-python)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/227040

Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Ryan Moe (rmoe)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/227040
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=489d39859910dafff12190a6ec515f8718dd3ceb
Submitter: Jenkins
Branch: master

commit 489d39859910dafff12190a6ec515f8718dd3ceb
Author: Ryan Moe <email address hidden>
Date: Wed Sep 23 15:28:50 2015 -0700

    Improve network group validation

    The validation for creating network groups and updating
    them has been split into two independent methods. This
    This change also prevents a network group's nodegroup from
    being changed.

    Change-Id: I0fb6e9c5f77effa8f1c81014f6151dafd98357d8
    Closes-bug: #1494842
    Closes-bug: #1494974

Changed in fuel:
status: In Progress → Fix Committed
Ryan Moe (rmoe)
summary: - API requests network group id where it is not required
- (NetworkGroupHandler)
+ Network groups can not be modified with Fuel CLI
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-web (stable/7.0)

Related fix proposed to branch: stable/7.0
Review: https://review.openstack.org/232025

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/7.0)

Fix proposed to branch: stable/7.0
Review: https://review.openstack.org/232428

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-web (stable/7.0)

Change abandoned by Artem Roma (<email address hidden>) on branch: stable/7.0
Review: https://review.openstack.org/232025
Reason: The patch was not properly backported

Revision history for this message
Vitaly Sedelnik (vsedelnik) wrote :

Targeted to 7.0-mu-1 because this fix is required by https://bugs.launchpad.net/fuel/+bug/1500308

Dmitry Pyzhov (dpyzhov)
tags: added: 70mu1-confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/7.0)

Reviewed: https://review.openstack.org/232428
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=f7dac02379d706926757fca6c0fb42a2e2c7dcb2
Submitter: Jenkins
Branch: stable/7.0

commit f7dac02379d706926757fca6c0fb42a2e2c7dcb2
Author: Ryan Moe <email address hidden>
Date: Wed Sep 23 15:28:50 2015 -0700

    Improve network group validation

    The validation for creating network groups and updating
    them has been split into two independent methods.
    This change also prevents a network group's nodegroup from
    being changed.

    Change-Id: I0fb6e9c5f77effa8f1c81014f6151dafd98357d8
    Closes-bug: #1494842
    Closes-bug: #1494974

Revision history for this message
Anastasia Palkina (apalkina) wrote :

Verified on ISO #163

"fuel-createmirror_sha": "fe81731b76071dc0a4ffdf039080732243f5a871", "api": "1.0", "fuelmain_sha": "a2d78bdf7b37d8f2658c9f0f1f43708bdf85f8cd", "astute_sha": "a090546d43c770ac27ca81c6f8c78ff0ba4a93e0", "fuel-ostf_sha": "17a093c05b972c2dd47f2c57775086d96caa5dfb", "openstack_version": "2015.1.0-8.0", "build_id": "163", "build_number": "163", "auth_required": true, "fuel-library_sha": "a0044771e18b404de1346e2a995fd215dddb5806", "fuel-nailgun-agent_sha": "08e0a11cf1f29b705e4b910d9b9db5e9b708b6e3", "fuel-nailgun_sha": "1e9f5dfdf811795637d726c3d7d959e63a25bca1", "fuel-agent_sha": "49e2e8a08a3cf39d1b38ee155015332aa84e47fd", "production": "docker", "python-fuelclient_sha": "b619bc86bba311b7bced66783833fa0454d99e9b", "feature_groups": ["mirantis"], "release": "8.0", "release_versions": {"2015.1.0-8.0": {"VERSION": {"fuel-createmirror_sha": "fe81731b76071dc0a4ffdf039080732243f5a871", "api": "1.0", "fuelmain_sha": "a2d78bdf7b37d8f2658c9f0f1f43708bdf85f8cd", "astute_sha": "a090546d43c770ac27ca81c6f8c78ff0ba4a93e0", "fuel-ostf_sha": "17a093c05b972c2dd47f2c57775086d96caa5dfb", "openstack_version": "2015.1.0-8.0", "build_id": "163", "build_number": "163", "fuel-library_sha": "a0044771e18b404de1346e2a995fd215dddb5806", "fuel-nailgun-agent_sha": "08e0a11cf1f29b705e4b910d9b9db5e9b708b6e3", "fuel-nailgun_sha": "1e9f5dfdf811795637d726c3d7d959e63a25bca1", "fuel-agent_sha": "49e2e8a08a3cf39d1b38ee155015332aa84e47fd", "production": "docker", "python-fuelclient_sha": "b619bc86bba311b7bced66783833fa0454d99e9b", "feature_groups": ["mirantis"], "release": "8.0"}}}

Changed in fuel:
status: Fix Committed → Fix Released
Dmitry Pyzhov (dpyzhov)
tags: added: area-python
tags: added: on-verification
Revision history for this message
Anastasia Palkina (apalkina) wrote :

Verified on Release ISO 7.0 + fuel-provisioning-scripts-7.0.0-7679.1.git433d7ab.noarch

tags: removed: on-verification
tags: added: verified
tags: added: 7mu1-verified
removed: verified
tags: removed: 70mu1-confirmed
Revision history for this message
Nastya Urlapova (aurlapova) wrote :

Moved to Fix Released according to a comment above.

tags: removed: 7mu1-verified
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.