deployment-create raises an exception

Bug #1494672 reported by Yingzhe Zeng
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-heatclient
Fix Released
High
Rabi Mishra

Bug Description

I tried to create a deployment with latest master code, by following command:
heat -d deployment-create -c 374f0a89-f5ca-43db-b96a-f1f720ddec11 -s 05fe8f38-5dbb-4028-abe1-2bd493b0ad47 -t NO_SIGNAL my_deploy_name

Then I got a exception like this:
Traceback (most recent call last):
  File "/usr/local/bin/heat", line 11, in <module>
    sys.exit(main())
  File "/usr/local/lib/python2.7/dist-packages/heatclient/shell.py", line 705, in main
    HeatShell().main(args)
  File "/usr/local/lib/python2.7/dist-packages/heatclient/shell.py", line 655, in main
    args.func(client, args)
  File "/usr/local/lib/python2.7/dist-packages/heatclient/v1/shell.py", line 1293, in do_deployment_create
    signal_id=deployment_utils.build_signal_id(hc, args)
  File "/usr/local/lib/python2.7/dist-packages/heatclient/common/deployment_utils.py", line 28, in build_derived_config_params
    inputs = copy.deepcopy(source.get('inputs')) or []
TypeError: get() takes exactly 1 argument (2 given)

Seems at this situation, the type of "source" object is SoftwareConfig, and SoftwareConfig's "get" method only takes one argument.

Rabi Mishra (rabi)
Changed in python-heatclient:
assignee: nobody → Rabi Mishra (rabi)
Changed in python-heatclient:
status: New → Triaged
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-heatclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/223004

Changed in python-heatclient:
status: Triaged → In Progress
Changed in python-heatclient:
milestone: none → 0.8.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-heatclient (master)

Reviewed: https://review.openstack.org/223004
Committed: https://git.openstack.org/cgit/openstack/python-heatclient/commit/?id=8eb188457d9cf7056eea401c4ade6154eab24ede
Submitter: Jenkins
Branch: master

commit 8eb188457d9cf7056eea401c4ade6154eab24ede
Author: Rabi Mishra <email address hidden>
Date: Mon Sep 14 11:26:13 2015 +0530

    Fix deployment create error when using existing config

    We use an empty dict as config when deployment is created
    without a config. This fixes 'build_derived_config_params'
    to accept both SoftwareConfig object and empty dict.

    Change-Id: Ib9b49e72c117aedc15966c11dafa43eca9e57dac
    Closes-Bug: #1494672

Changed in python-heatclient:
status: In Progress → Fix Committed
Changed in python-heatclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.