Magic Search filtering should provide default help content

Bug #1494532 reported by Cindy Lu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Cindy Lu

Bug Description

As suggested by Travis here: https://review.openstack.org/#/c/217437/3/openstack_dashboard/static/app/core/images/table/images-table.controller.js

Instead of defining

ctrl.sourceFilterStrings = {
      cancel: gettext('Cancel'),
      prompt: gettext('Click here for filters.'),
      remove: gettext('Remove'),
      text: gettext('In current results')
}

everywhere, we can just make it a default in hzMagicSearchBar directive. If user doesn't pass in any filterStrings, we use the default instead.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/222710

Changed in horizon:
assignee: nobody → Cindy Lu (clu-m)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/222710
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=bb60aa4a33952f1d9bdea5c6a0646e9210952f48
Submitter: Jenkins
Branch: master

commit bb60aa4a33952f1d9bdea5c6a0646e9210952f48
Author: Cindy Lu <email address hidden>
Date: Thu Sep 10 01:24:06 2015 -0700

    Angular Magic Search defaults for filterStrings

    Rather that repeatedly defining the filter help text every time
    Magic Search is defined, we can make filterStrings optional.
    If it's not provided, we can use the defaults.

    Based off TravT's suggestion in images-table.controller.js here:
    https://review.openstack.org/#/c/217437/2/

    To test, rebase one of the Magic Search implementations on this patch.
    (e.g https://review.openstack.org/#/c/217437/) and remove filterStrings:

       <hz-magic-search-bar
         filter-facets="filterFacets">
       </hz-magic-search-bar>

    Change-Id: I9968c95da85063cbff81bc1ed4b15679dfaf58b7
    Closes-Bug: #1494532

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
milestone: none → liberty-rc1
importance: Undecided → Low
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: liberty-rc1 → 8.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.