Staff client refund option generates an error
Bug #1494427 reported by
Kathy Lussier
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Medium
|
Unassigned |
Bug Description
Evergreen version: 2.9RC
Tested on the MassLNC community demo server. Retrieve a patron record with a negative balance in the patron's bills interface, right-click on the transaction and select the "Refund" option. The client generates the following error:
*** Failed to get string staff.patron.
undefined
Changed in evergreen: | |
milestone: | none → 2.9.0 |
Changed in evergreen: | |
status: | New → Confirmed |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
This working branch restores the refund function back to its behavior in 2.8:
http:// git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ kmlussier/ lp1494427- fix-refund- error
However, I also want to make note that, although I've added the staff.patron. bills.handle_ refund. confirm_ message back to the patron.properties file, as far as I can tell, this string never gets displayed. It didn't display in 2.8 either.
I was tempted to just remove the string from the handle_refund function in bill2.js, but I was worried that the string was being displayed somewhere and I was just missing it. I'm happy to do a new branch to remove the string from the function if it's a better approach.
Test case:
Find a negative balance transaction and, from the patron's bills
record, select the transaction and select the option to Refund. Pre-patch, this
action will generate an error message. Post-patch, this action should generate
a prompt asking the user to confirm the action.