Gnocchi uses minified source-less JS files

Bug #1494348 reported by Thomas Goirand
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Gnocchi
Fix Released
Low
Julien Danjou

Bug Description

Hi,

In Gnocchi sources, I could see:

$ find . -iname '*.min.js'
./gnocchi/rest/static/js/c3.min.js
./gnocchi/rest/static/js/d3.min.js
./gnocchi/rest/static/js/bootstrap.min.js

1/ Please don't use embedded javascripts, but what's available in the system. Horizon already packaged d3 and bootstrap as python-xstatic packages, if you want to use that.

2/ Even less provide source-less minified javascripts. That's non-free for any distribution around. I'd also would like to point out that this may be a potential security issue:

https://zyan.scripts.mit.edu/blog/backdooring-js/

Until this is fixed, and a new Gnocchi version is released, I can't unfortunately, upload Gnocchi to Debian, even though all of the packaging is ready in git.debian.org.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to gnocchi (master)

Fix proposed to branch: master
Review: https://review.openstack.org/222229

Changed in gnocchi:
assignee: nobody → Julien Danjou (jdanjou)
status: New → In Progress
Julien Danjou (jdanjou)
Changed in gnocchi:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to gnocchi (master)

Reviewed: https://review.openstack.org/222229
Committed: https://git.openstack.org/cgit/openstack/gnocchi/commit/?id=36186fe63d11b7cadac43ec61293897a5a9c36c9
Submitter: Jenkins
Branch: master

commit 36186fe63d11b7cadac43ec61293897a5a9c36c9
Author: Julien Danjou <email address hidden>
Date: Thu Sep 10 16:50:05 2015 +0200

    rest: remove the Web interface

    This never has been completed and will very probably never be as it's
    not complicated to build for us and to use for the users.

    There are other solution out there we are working on and that are way
    more interesting such as Grafana.

    Change-Id: I8f473f07e033a521f46a52da48b7593891a6a3d2
    Closes-Bug: #1494348

Changed in gnocchi:
status: In Progress → Fix Committed
Julien Danjou (jdanjou)
Changed in gnocchi:
milestone: none → 1.2.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.