CMakeLists.txt for "tokudb-backup-plugin" does not include Valgrind dependency

[Yura Sorokin]

Tried to build percona-servrer 5.6 (commit 7416cc0) on a CentOS 7 machine without "valgring-devel" package installed.

cmake ../percona-server \
 -DBUILD_CONFIG=mysql_release \
 -DCMAKE_BUILD_TYPE=Debug \
 -DDEBUG_EXTNAME=OFF \
 -DWITH_EMBEDDED_SERVER=OFF \
 -DFEATURE_SET=community \
 -DENABLE_DTRACE=OFF \
 -DWITH_SSL=system \
 -DWITH_PAM=ON \
 -DWITH_INNODB_MEMCACHED=ON

Please, notice no "-DWITH_VALGRING=ON" option.

make

[ 93%] Building CXX object plugin/tokudb-backup-plugin/Percona-TokuBackup/backup/CMakeFiles/HotBackup.dir/manager.cc.o
/home/yura/ws/percona-server/plugin/tokudb-backup-plugin/Percona-TokuBackup/backup/manager.cc:57:31: fatal error: valgrind/helgrind.h: No such file or directory
 #include <valgrind/helgrind.h>
                               ^
compilation terminated.
make[2]: *** [plugin/tokudb-backup-plugin/Percona-TokuBackup/backup/CMakeFiles/HotBackup.dir/manager.cc.o] Error 1
make[1]: *** [plugin/tokudb-backup-plugin/Percona-TokuBackup/backup/CMakeFiles/HotBackup.dir/all] Error 2
make: *** [all] Error 2

[Tomislav Plavcic (tplavcic)]

Seems to me this is actually not in a tokudb-backup-plugin but Percona-TokuBackup which means it's in a submodule and is used in other Toku products and not only in PS - solution should take this into consideration - not sure if it makes a difference but just a note.

[Ken Zalewski (ken-zalewski)]

Same problem here.

<valgrind/helgrind.h> is required, since it is not wrapped in any conditional logic.

[Tomislav Plavcic (tplavcic)]

PR: https://github.com/percona/Percona-TokuBackup/pull/73

[Shahriyar Rzayev (rzayev-sehriyar)]

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PS-1650