Policy check is missing for FWaaS rules table

[Tatiana Ovchinnikova]

There is firewall policy column in FWaaS rules table:

firewall_policy_id = tables.Column(get_policy_name,
                                       link=get_policy_link,
                                       verbose_name=_("In Policy"))

Method "get_policy_name" checks if there is a policy to display, but "get_policy_link" doesn't, so when we try to add a new firewall rule (which has no policy connection by default), horizon can't display FWaaS tables because of "'NoneType' object has no attribute 'id'".

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/222102

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/222102
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=9022617d9a3faa311842d34e708d42abca8e6a1b
Submitter: Jenkins
Branch: master

commit 9022617d9a3faa311842d34e708d42abca8e6a1b
Author: Tatiana Ovchinnikova <email address hidden>
Date: Thu Sep 10 12:52:55 2015 +0300

    Fix FWaaS Rules table displaying

    When we try to add a new firewall rule, it has no policy connection
    by default: we should use "Insert Rule" from Policies table. However,
    horizon can't display FWaaS tables anymore, breaking with error:
    "'NoneType' object has no attribute 'id'". This patch adds a policy
    check to "get_policy_link" method to show firewall rules without
    policy connections.

    Closes-Bug: #1494216

    Change-Id: Iab283181428ede84cbc020ebf52a171714f56fa1

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/258290

[OpenStack Infra (hudson-openstack)]

Change abandoned by Dave Walker (<email address hidden>) on branch: stable/kilo
Review: https://review.openstack.org/258290
Reason: Kilo is now approaching EOL. We are in freeze pending the final release and no freeze exception has been raised. Therefore I am abandoning this change, if it is required in the release - please restore and raise a request. Thanks