duplicated pipeline support meter check when publish samples

Bug #1494156 reported by Liusheng
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Invalid
Low
Wenzhi Yu
Juno
Won't Fix
Low
Wenzhi Yu
Kilo
Won't Fix
Low
Wenzhi Yu

Bug Description

see[1], when publishing sample with sample pipeline, it will check the samples supported by the source definition of the pipeline or not, but the samples is always supported by this pipeline, because when setup polling tasks, the pollster has been checked and matched corresponding pipeline, see[2]. so the samples from the pollsters is always supported by the pipeline. this check has no affect of the publishing result, but will cost cpu resources if we have a complex pipeline definition.

[1] https://github.com/openstack/ceilometer/blob/stable/kilo/ceilometer/pipeline.py#L503

[2] https://github.com/openstack/ceilometer/blob/stable/kilo/ceilometer/agent/base.py#L274-L283

this bug affect Kilo and Juno

Liusheng (liusheng)
no longer affects: ceilometer (Ubuntu)
tags: added: kilo
Liusheng (liusheng)
tags: removed: kilo
Liusheng (liusheng)
description: updated
Wenzhi Yu (yuywz)
Changed in ceilometer:
assignee: nobody → Wen Zhi Yu (yuywz)
Changed in ceilometer:
status: New → In Progress
Changed in ceilometer:
assignee: Wen Zhi Yu (yuywz) → Rohit Jaiswal (rohit-jaiswal-3)
Changed in ceilometer:
assignee: Rohit Jaiswal (rohit-jaiswal-3) → Wen Zhi Yu (yuywz)
Revision history for this message
Lianhao Lu (lianhao-lu) wrote :

I think the check is necessary in Liberty code. Please see my comment at https://review.openstack.org/#/c/222504/, so please mark this only affect kilo/juno branch

gordon chung (chungg)
Changed in ceilometer:
importance: Undecided → Low
status: In Progress → Invalid
Revision history for this message
gordon chung (chungg) wrote :

is there a way to do this without touching model? if not, this isn't worth the effort i think.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on ceilometer (master)

Change abandoned by Wen Zhi Yu (<email address hidden>) on branch: master
Review: https://review.openstack.org/222504
Reason: Since this issue just affect Juno/Kilo, abandoning this change.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.