OpenStack Dashboard (Horizon)

Image form "format" field is not being auto-completed (again)

Bug #1494149 reported by Richard Jones
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Richard Jones
OpenStack Dashboard (Horizon) mitaka-1 "m1"

Bug Description

Selenium is again detecting (correctly) that the Create Image form "format" field isn't being auto-filled when a file is selected (eg. a .iso).

It appears that the angular ImageFormController isn't even active in the page, though the reason hasn't been determined yet. I suspect a recent commit has broken it because it was working.

Richard Jones (r1chardj0n3s)
Changed in horizon:
assignee: nobody → Richard Jones (r1chardj0n3s)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/222438

Changed in horizon:
status: New → In Progress
Revision history for this message
Lin Hua Cheng (lin-hua-cheng) wrote :

I'd like to include this for RC2, it is one of the blocker to eventually getting selenium passing.

If we can get selenium passing by RC2, we can enable gate on selenium for stable/liberty.

tags: added: liberty-rc2-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/222438
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=0f39dea2c7e722781fe3374abbaada781488c2cc
Submitter: Jenkins
Branch: master

commit 0f39dea2c7e722781fe3374abbaada781488c2cc
Author: Richard Jones <email address hidden>
Date: Fri Sep 11 12:09:32 2015 +1000

    Fix loading of angular in jquery modals

    This patch fixes the invocation of the loadAngular method
    which started failing (silently) when moved out of an
    angular module context (variables it required were not
    defined.

    This patch also removes the try/catch that was silently
    squashing errors, and adds documentation in the code
    to explain what the loadAngular function's purpose
    is.

    Change-Id: I95382e89b5e8098af596319730328480c85e324d
    Closes-Bug: 1494149

Changed in horizon:
status: In Progress → Fix Committed
Rob Cresswell (robcresswell-deactivatedaccount)
Changed in horizon:
milestone: none → mitaka-1
importance: Undecided → High
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/horizon 9.0.0.0b1

This issue was fixed in the openstack/horizon 9.0.0.0b1 development milestone.

Changed in horizon:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/299333

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (stable/liberty)

Change abandoned by Itxaka Serrano Garcia (<email address hidden>) on branch: stable/liberty
Review: https://review.openstack.org/299333
Reason: liberty is only for critical/security

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.