worker/uniter/remotestate: data race

Bug #1494121 reported by Dave Cheney
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
juju-core
Fix Released
Critical
Andrew Wilkins

Bug Description

==================
WARNING: DATA RACE
Write by goroutine 74:
  runtime.mapdelete()
      /home/dfc/go/src/runtime/hashmap.go:513 +0x0
  github.com/juju/juju/worker/uniter/remotestate_test.(*WatcherSuite).TestStorageUnattachedChanged()
      /home/dfc/src/github.com/juju/juju/worker/uniter/remotestate/watcher_test.go:388 +0xf13
  runtime.call32()
      /home/dfc/go/src/runtime/asm_amd64.s:442 +0x3d
  reflect.Value.Call()
      /home/dfc/go/src/reflect/value.go:300 +0xcd
  gopkg.in/check%2ev1.(*suiteRunner).forkTest.func1()
      /home/dfc/src/gopkg.in/check.v1/check.go:772 +0x5e0
  gopkg.in/check%2ev1.(*suiteRunner).forkCall.func1()
      /home/dfc/src/gopkg.in/check.v1/check.go:666 +0x80

Previous read by goroutine 77:
  runtime.mapaccess2()
      /home/dfc/go/src/runtime/hashmap.go:320 +0x0
  github.com/juju/juju/worker/uniter/remotestate_test.(*mockState).StorageAttachment()
      /home/dfc/src/github.com/juju/juju/worker/uniter/remotestate/mock_test.go:111 +0x3b0
  github.com/juju/juju/worker/uniter/remotestate.getStorageSnapshot()
      /home/dfc/src/github.com/juju/juju/worker/uniter/remotestate/storagewatcher.go:67 +0xc3
  github.com/juju/juju/worker/uniter/remotestate.(*storageAttachmentWatcher).loop()
      /home/dfc/src/github.com/juju/juju/worker/uniter/remotestate/storagewatcher.go:91 +0x2f7
  github.com/juju/juju/worker/uniter/remotestate.newStorageAttachmentWatcher.func1()
      /home/dfc/src/github.com/juju/juju/worker/uniter/remotestate/storagewatcher.go:33 +0xd8

Goroutine 74 (running) created at:
  gopkg.in/check%2ev1.(*suiteRunner).forkCall()
      /home/dfc/src/gopkg.in/check.v1/check.go:667 +0x486
  gopkg.in/check%2ev1.(*suiteRunner).forkTest()
      /home/dfc/src/gopkg.in/check.v1/check.go:804 +0x126
  gopkg.in/check%2ev1.(*suiteRunner).runTest()
      /home/dfc/src/gopkg.in/check.v1/check.go:809 +0x38
  gopkg.in/check%2ev1.(*suiteRunner).run()
      /home/dfc/src/gopkg.in/check.v1/check.go:615 +0x481
  gopkg.in/check%2ev1.Run()
      /home/dfc/src/gopkg.in/check.v1/run.go:92 +0x50
  gopkg.in/check%2ev1.RunAll()
      /home/dfc/src/gopkg.in/check.v1/run.go:84 +0x133
  gopkg.in/check%2ev1.TestingT()
      /home/dfc/src/gopkg.in/check.v1/run.go:72 +0x4b5
  github.com/juju/juju/worker/uniter/remotestate_test.TestPackage()
      /home/dfc/src/github.com/juju/juju/worker/uniter/remotestate/package_test.go:13 +0x2e
  testing.tRunner()
      /home/dfc/go/src/testing/testing.go:456 +0xdc

Goroutine 77 (running) created at:
  github.com/juju/juju/worker/uniter/remotestate.newStorageAttachmentWatcher()
      /home/dfc/src/github.com/juju/juju/worker/uniter/remotestate/storagewatcher.go:34 +0x1c8
  github.com/juju/juju/worker/uniter/remotestate.(*RemoteStateWatcher).watchStorageAttachment()
      /home/dfc/src/github.com/juju/juju/worker/uniter/remotestate/watcher.go:657 +0x625
  github.com/juju/juju/worker/uniter/remotestate.(*RemoteStateWatcher).storageChanged()
      /home/dfc/src/github.com/juju/juju/worker/uniter/remotestate/watcher.go:601 +0xc76
  github.com/juju/juju/worker/uniter/remotestate.(*RemoteStateWatcher).loop()
      /home/dfc/src/github.com/juju/juju/worker/uniter/remotestate/watcher.go:351 +0x26a9
  github.com/juju/juju/worker/uniter/remotestate.NewWatcher.func1()
      /home/dfc/src/github.com/juju/juju/worker/uniter/remotestate/watcher.go:84 +0x9b
==================
OK: 15 passed
PASS
Found 1 data race(s)
exit status 66
FAIL github.com/juju/juju/worker/uniter/remotestate 2.072s

Ian Booth (wallyworld)
Changed in juju-core:
importance: Undecided → Critical
status: New → Triaged
milestone: none → 1.26-alpha1
Ian Booth (wallyworld)
Changed in juju-core:
assignee: nobody → Andrew Wilkins (axwalk)
Andrew Wilkins (axwalk)
Changed in juju-core:
status: Triaged → In Progress
Revision history for this message
Andrew Wilkins (axwalk) wrote :
Andrew Wilkins (axwalk)
Changed in juju-core:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
Changed in juju-core:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.