solidifre update_provider_info not returning a tuple

[John Griffith]

The SolidFire driver isn't updating snapshot records for the update_provider_info call, it's still only returning the volume-updates causing the SF-CI system to error out because the manager call is expecting a tuple:

2015-09-08 20:35:47.713 ERROR oslo_service.threadgroup [req-7c624e4a-9e2f-493d-9ac1-f260f82d85ee None] need more than 0 values to unpack
2015-09-08 20:35:47.713 13632 ERROR oslo_service.threadgroup Traceback (most recent call last):
2015-09-08 20:35:47.713 13632 ERROR oslo_service.threadgroup File "/usr/local/lib/python2.7/dist-packages/oslo_service/threadgroup.py", line 154, in wait
2015-09-08 20:35:47.713 13632 ERROR oslo_service.threadgroup x.wait()
2015-09-08 20:35:47.713 13632 ERROR oslo_service.threadgroup File "/usr/local/lib/python2.7/dist-packages/oslo_service/threadgroup.py", line 51, in wait
2015-09-08 20:35:47.713 13632 ERROR oslo_service.threadgroup return self.thread.wait()
2015-09-08 20:35:47.713 13632 ERROR oslo_service.threadgroup File "/usr/local/lib/python2.7/dist-packages/eventlet/greenthread.py", line 175, in wait
2015-09-08 20:35:47.713 13632 ERROR oslo_service.threadgroup return self._exit_event.wait()
2015-09-08 20:35:47.713 13632 ERROR oslo_service.threadgroup File "/usr/local/lib/python2.7/dist-packages/eventlet/event.py", line 121, in wait
2015-09-08 20:35:47.713 13632 ERROR oslo_service.threadgroup return hubs.get_hub().switch()
2015-09-08 20:35:47.713 13632 ERROR oslo_service.threadgroup File "/usr/local/lib/python2.7/dist-packages/eventlet/hubs/hub.py", line 294, in switch
2015-09-08 20:35:47.713 13632 ERROR oslo_service.threadgroup return self.greenlet.switch()
2015-09-08 20:35:47.713 13632 ERROR oslo_service.threadgroup File "/usr/local/lib/python2.7/dist-packages/eventlet/greenthread.py", line 214, in main
2015-09-08 20:35:47.713 13632 ERROR oslo_service.threadgroup result = function(*args, **kwargs)
2015-09-08 20:35:47.713 13632 ERROR oslo_service.threadgroup File "/usr/local/lib/python2.7/dist-packages/oslo_service/service.py", line 645, in run_service
2015-09-08 20:35:47.713 13632 ERROR oslo_service.threadgroup service.start()
2015-09-08 20:35:47.713 13632 ERROR oslo_service.threadgroup File "/opt/stack/cinder/cinder/service.py", line 146, in start
2015-09-08 20:35:47.713 13632 ERROR oslo_service.threadgroup self.manager.init_host()
2015-09-08 20:35:47.713 13632 ERROR oslo_service.threadgroup File "/usr/local/lib/python2.7/dist-packages/osprofiler/profiler.py", line 105, in wrapper
2015-09-08 20:35:47.713 13632 ERROR oslo_service.threadgroup return f(*args, **kwargs)
2015-09-08 20:35:47.713 13632 ERROR oslo_service.threadgroup File "/opt/stack/cinder/cinder/volume/manager.py", line 380, in init_host
2015-09-08 20:35:47.713 13632 ERROR oslo_service.threadgroup self._sync_provider_info(ctxt, volumes)
2015-09-08 20:35:47.713 13632 ERROR oslo_service.threadgroup File "/opt/stack/cinder/cinder/volume/manager.py", line 326, in _sync_provider_info
2015-09-08 20:35:47.713 13632 ERROR oslo_service.threadgroup updates, snapshot_updates = self.driver.update_provider_info(volumes)
2015-09-08 20:35:47.713 13632 ERROR oslo_service.threadgroup ValueError: need more than 0 values to unpack

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/221510

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/221510
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=81de3ea731066feb40c2db9ca95ec0c67d65de1a
Submitter: Jenkins
Branch: master

commit 81de3ea731066feb40c2db9ca95ec0c67d65de1a
Author: John Griffith <email address hidden>
Date: Tue Sep 8 15:29:05 2015 -0600

    Return a tuple from SolidFire update_provider_info

    The SolidFire update_provider_info is only returning
    a list of updated volumes, but the manager call (and
    the method def in the reference) calls for a tuple of
    volumes and snapshots.

    This patch fixes the return to be a tuple, a follow on
    will be needed to add snapshot updates.

    Change-Id: Ifa617bfd7b0652adf7bf1b19d48e88bfcfcec8df
    Partial-Bug: #1493563