no_proxy isn't correctly set if don't provide no_proxy when create baymodel

[Eli Qiao]

no_proxy in swarm node is not correct if we don't pass no_proxy.

check the logic here: #https://github.com/openstack/magnum/blob/master/magnum/templates/docker-swarm/fragments/add-proxy.sh#L38

steps to reproduce:
magnum baymodel-create --name swarmmodel --image-id fedora-21-atomic-3 --keypair-id testkey --external-network-id $NIC_ID --dns-nameserver 10.248.2.5 --flavor-id m1.small --docker-volume-size 5 --coe swarm --fixed-network 192.168.0.0/24 --http-proxy http://10.239.4.160:911/ --https-proxy https://10.239.4.160:911/

magnum bay-create --name swarmbay --baymodel swarmmodel --node-count 2

login into swarm-master and swarm-node:
heat-parameter and no_proxy in /etc/bashrc is not correct

http://paste.openstack.org/show/449787/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/221212

[Eli Qiao (taget-9)]

with this patch, I got these:

bash-4.3# cat /etc/sysconfig/heat-params
WAIT_HANDLE="http://10.238.157.47:8000/v1/waitcondition/arn%3Aopenstack%3Aheat%3A%3A88a7eddf94f74be7bd9ec30c12b3b1c7%3Astacks%2Fswarmbay-fee2n5ukmj2w%2F91c725c9-2acc-4307-a675-ddf7e9f74014%2Fresources%2Fmaster_wait_handle?Timestamp=2015-09-08T09%3A14%3A22Z&SignatureMethod=HmacSHA256&AWSAccessKeyId=5ff00a1786bd487b9f11daf06434fbed&SignatureVersion=2&Signature=CR3pWAl%2FFikfY%2FvIQM6MHaDs0G03o5eeqXNFSQmgYbs%3D"
HTTP_PROXY="http://10.239.4.160:911/"
HTTPS_PROXY="https://10.239.4.160:911/"
NO_PROXY=""
SWARM_MASTER_IP="192.168.0.3"
NODE_COUNT="2"

bash-4.3# cat /etc/bashrc | grep no_proxy=
declare -x no_proxy="192.168.0.3,192.168.0.4,192.168.0.5"

[OpenStack Infra (hudson-openstack)]

Change abandoned by Adrian Otto (<email address hidden>) on branch: master
Review: https://review.openstack.org/221212
Reason: This patch has not seen any revisions in a long time. We want our review queue to contain active work-in-progress and code that reviewers are considering for merge. You are welcome to un-abandon this at any time, and continue making revisions.

[rajiv (rajiv-kumar)]

For swarm, this issue is reproducible. When no no_proxy is not specified then it sets its own IP three, for exmaple

magnum cluster-template-show swarm-cluster-template-customized
+-----------------------+---------------------------------------------+
| Property | Value |
+-----------------------+---------------------------------------------+
| insecure_registry | - |
| labels | {'flannel_network_cidr': '192.168.10.0/24'} |
| updated_at | - |
| floating_ip_enabled | True |
| fixed_subnet | private-subnet |
| master_flavor_id | - |
| uuid | 025e2e73-3055-4f76-9033-a079c9262ce4 |
| no_proxy | - |
| https_proxy | - |
| tls_disabled | False |
| keypair_id | testkey |
| public | False |
| http_proxy | 172.30.66.104 |
| docker_volume_size | 5 |
| server_type | vm |
| external_network_id | public |
| cluster_distro | fedora-atomic |
| image_id | fedora-atomic-latest |
| volume_driver | - |
| registry_enabled | False |
| docker_storage_driver | devicemapper |
| apiserver_port | - |
| name | swarm-cluster-template-customized |
| created_at | 2016-09-06T03:24:58+00:00 |
| network_driver | docker |
| fixed_network | private |
| coe | swarm |
| flavor_id | m1.small |
| master_lb_enabled | False |
| dns_nameserver | 8.8.8.8 |
+-----------------------+---------------------------------------------+

And no_proxy is following in master node.
no_proxy="10.0.0.12,10.0.0.12,10.0.0.12".

And on swarm node
no_proxy="10.0.0.12,10.0.0.12,10.0.0.9"

[OpenStack Infra (hudson-openstack)]

Change abandoned by Eli Qiao (<email address hidden>) on branch: master
Review: https://review.openstack.org/221212