manila devstack plugin can not register keypair

[Valeriy Ponomaryov]

Recently appeared error in installation of Manila using our Devstack plugin, and our gates are broken because of it. See [1]

Here is raw error:

2015-09-07 10:34:37.876 | ++ echo_summary 'Creating Manila service keypair'
2015-09-07 10:34:37.877 | ++ [[ -t 3 ]]
2015-09-07 10:34:37.877 | ++ echo -e Creating Manila service keypair
2015-09-07 10:34:37.877 | ++ create_manila_service_keypair
2015-09-07 10:34:37.877 | ++ openstack keypair create manila-service --public-key /opt/stack/new/.ssh/id_rsa.pub
2015-09-07 10:34:38.786 | ERROR: openstack Invalid input for field/attribute keypair. Value: {u'public_key': u'ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDERprUOW0xDCnppjK3Orl+29Ow2YosjinVWqiw4hF1r/59SD+7aW1nOdlrHhWiG/vfeltKh8nfc8xvNikWbo1+SVDawDRVQKHIOYQV9ydKAiBOH0kzmMv8dHrPnpP+ye9Y+VQDqjLFkIAQa0zl5WpWNxzNMK2AcOAcQ0r7OkJjF9kSQy7XZYbCQb9rynuUyzLO3gCHRJwA7L7F8aPHzv7rnZEhqqbnWRx3vpurJgzEGJa5TcAMIMGxNcSUANEjdivWbUCX+VqD/dVAwS9BPQFmCP+pw7cpd1V2c1r4B6wcCRZIiJv00mucbHfXGO9+rTHzI5rHKbcWyBlcN9x65/ef stack@devstack-trusty-rax-dfw-4797418\n', u'type': u'ssh', u'name': u'manila-service'}. Additional properties are not allowed (u'type' was unexpected) (HTTP 400) (Request-ID: req-dfa2c5d2-c8e3-4fb1-976b-6e84fc37e614)
2015-09-07 10:34:38.819 | + exit_trap

[1] http://logs.openstack.org/34/219934/1/check/gate-manilaclient-dsvm-neutron-functional/aa7a616/logs/devstacklog.txt.gz#_2015-09-07_10_34_37_877

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/220972

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/220972
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=f88c2aaeead716420538327a5df80be6a0765899
Submitter: Jenkins
Branch: master

commit f88c2aaeead716420538327a5df80be6a0765899
Author: Valeriy Ponomaryov <email address hidden>
Date: Mon Sep 7 15:19:05 2015 +0300

    Fix keypair creation

    Use novaclient for creation of keypair instead of openstack client in
    devstack plugin, because the latter is not compatible with
    nova microversion 2.1

    Also, specify explicitly Nova API version in manila wrapper over
    novaclient that is used by Generic and Windows drivers.

    Also, revert back amount of tempest threads for Ci jobs to avoid job
    timeout failures.

    Also, fix raise of SnapshotBuildErrorException in Tempest plugin.
    Tempest tries to raise exception SnapshotBuildErrorException from wrong
    place. It should use "share_exceptions" instead of "exceptions".

    Change-Id: Ie9ea9f6d25a13f8cd8f0ccbc73f6fa75cca35e0b
    Closes-Bug: #1493008
    Closes-Bug: #1493072