QoS: Sr-IOV Agent doens't clear VF rate when deleteing VM
Bug #1492909 reported by
Moshe Levi
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
neutron |
Fix Released
|
Low
|
Moshe Levi |
Bug Description
when launching VM with port with QoS policy and after a while deleting the VM the SR-IOV agent doesn't clear the VF max rate.
expected behavior is to delete VF max rate upon VM deletion.
Changed in neutron: | |
assignee: | nobody → Moshe Levi (moshele) |
tags: | added: qos |
Changed in neutron: | |
status: | New → In Progress |
Changed in neutron: | |
importance: | Undecided → Low |
milestone: | none → liberty-rc1 |
Changed in neutron: | |
status: | Fix Committed → Fix Released |
Changed in neutron: | |
milestone: | liberty-rc1 → 7.0.0 |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/214055 /git.openstack. org/cgit/ openstack/ neutron/ commit/ ?id=13901bdf694 1d17069073f4897 98faaa86151fae
Committed: https:/
Submitter: Jenkins
Branch: master
commit 13901bdf6941d17 069073f489798fa aa86151fae
Author: Moshe Levi <email address hidden>
Date: Tue Aug 18 08:48:24 2015 +0300
Qos SR-IOV: Refactor extension delete to get mac and pci slot
When calling delete we need the pci slot details to reset the VF rate. The problem
is that when the VM is deleted libvirt return the VF to the hypervisor and eswitch
manager will mark the pci_slot as unassigned so can't know from the mac which pci slot (VF)
to reset. Also newer libvirt version reset the mac when deleteing VM, so than it is
not possible at all.
The solution is to keep pci slot details locally in the agent since upon removal event
you cannot get pci_slot from the neutron server as it is for create/update since port
is already removed from neutron.
This patch pairs the mac and pci_slot for a device (VF) so when calling the extension
port delete api we can have the pci_slot and reset the VF rate.
It is also add a mapping between mac to port_id so we can pass the port_id
when calling the extention port delete api.
Partially- Implements: blueprint ml2-sriov- qos-with- bwlimiting de9c56b452dfab7 909c8d0a576
Closes-Bug: #1492909
Change-Id: Icc3a9599c6d7a4