Router set gateway has a error

Bug #1492667 reported by qiaomin032
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
qiaomin032

Bug Description

Reproduce the bug:
1, Create a router and it's name is router1;
2, Edit router and set it's name is blank, and it will display it's ID as name;
3;Click "Set Gateway" and open a form modal, select a "External Network", then click the "External Network" button, there will display "this field is required" beside the "Router Name" field.
But the set gateway api support router having no name. So when open the "Set Gateway" form modal, there should display the router's name_or_id.
Please see the attachment for more detail

Revision history for this message
qiaomin032 (chen-qiaomin) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/220770

Changed in horizon:
assignee: nobody → qiaomin032 (chen-qiaomin)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/220770
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=59752b64560ad90065721f803a0f8dafc80a0250
Submitter: Jenkins
Branch: master

commit 59752b64560ad90065721f803a0f8dafc80a0250
Author: chenqiaomin <chen.qiaomin@99cloud.net>
Date: Wed Jul 8 21:38:13 2015 -0400

    Fix a bug for "Set Gateway" form modal

    When set gateway for a router having no name, it cast error:
    "This field is required" for the router name. So there
    should display the router's name_or_id in "Set Gateway"
    form modal, and this is consistent with the "Edit Router".

    Change-Id: Ibfcbf90f20c2eeb8b5533f8f41d4efc68df3ffbb
    Closes-Bug: #1492667

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
milestone: none → liberty-rc1
importance: Undecided → High
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: liberty-rc1 → 8.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.