Undefined lang string for user search filter result

Bug #1492666 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon
15.10
Fix Released
Undecided
Unassigned

Bug Description

Mahara 15.10dev

When you filter for users who have logged in since a particular date or have never logged in and there is no result, the "No results found" string is not displayed. Instead an undefined string is shown.

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

Jen says it's related to the local caching. The same issue comes up when you are in your inbox and don't have notifications in at least 2 areas. The first one displays "No results found", but the second one only shows [[[undefined]]].

Changed in mahara:
assignee: nobody → Robert Lyon (robertl-9)
Robert Lyon (robertl-9)
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5234

Revision history for this message
Robert Lyon (robertl-9) wrote :

On first time around get_string_ajax() fetches string via ajax and adds it to strings js array

On subsequent times around it gets the string from the js array and it was this bit that was failing

Have fixed up now

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5234
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/316b2ab02ebe22c96b4a3713d18bac40aa423313
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 316b2ab02ebe22c96b4a3713d18bac40aa423313
Author: Robert Lyon <email address hidden>
Date: Tue Sep 8 14:15:35 2015 +1200

Bug 1492666: Mistake with js function.apply()

The first arg needs to be 'this'

behatnotneeded

Change-Id: If9af8acdd9274a617a90d020463708373fd806f9
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.