Favorites and Downloads buttons are mixed up

[Peter Bittner]

In the bottom-edge radial menu the two buttons Favorites and Downloads open the respective other page (Favorites icon -> Downloads page, Downloads icon -> Favorites page).

This is probably not intended and should be fixed.

[Peter Bittner (peter-bittner)]

Affected app: Google Apps

[Matti Rinta-Nikkola (matti-rintanikkola-d)]

Thanks Peter for the feedback!

I'm not sure exactly which are the two radial buttons which you would like to exchange with each other. I suppose the pages you mean are download and setup pages but there is no downloads icon in menu.
The radial menu button icons of the app in clockwise order and corresponding actions:

home opens app home page in webview
starred opens app download page
save set current page: 1) as app home page, 2) as site home page or 3) bookmarks it
settings opens app setup page from where you can access also info and application settings pages
add opens add website page

I agree that the starred icon might not be the perfect icon for the download page and I think also that the page should be called differently. I have called it also as a Global Bookmarks on info page. The download page has become like a small web directory service where the downloading website configurations to the app is not any more the only function of the page but you can also check websites security using http://urlcheck.info/ and open websites externally to the browser app.

[Matti Rinta-Nikkola (matti-rintanikkola-d)]

sorry badly formatted response.... I try again
The radial menu button icons of the app in clockwise order and corresponding actions:

home: >>>> opens app home page in webview
starred:>>> opens app download page
save:>>>>> set current page: 1) as app home page, 2) as site home page or 3) bookmarks it
settings:>> opens app setup page from where you can access also info and application settings pages
add:>>>>>> opens add website page

[Peter Bittner (peter-bittner)]

Okay, I see. So, it's more of a usability issue:

1.) The Starred icons opens a page titled "Download" (where you would expect something that works like bookmarks / favourites).

2.) The Save icon (which is roughly "download something to disk") opens a dialog which doesn't show any *file* or the like being saved (downloaded to) somewhere.

The technical functioning may be correct, it's just that the meaning of the buttons is not clear. Could you try to find icons that represent better what the function is about? (Intuitively, I would say the Save action should have the Star as an icon, because you do set bookmarks and similar things with it!)

An additional suggestion:

- The Save action (= what I call "download" icon) opens a dialog titled "Set". This is irritating. (issue #1 The icon doesn't match the dialog title. Neither does the name Save you give it, btw.)
- Then the dialog shows 3 green buttons ("safe actions") and two red buttons ("destructive actions"). Isn't the purpose of the dialog to
   a,) either set the current page as the App Homepage, Website Homepage, or as a Bookmark? (-> radio buttons)
   b,) or reset the Website Homepage? (What is this, btw?)

So, there should be
  i.) 3 radio buttons (App Home, Web Home, Bookmark)
  ii.) 2 gray action buttons saying "OK" and "Cancel"
  iii.) 1 red action button saying "Reset Web" (though the relation to the above group established by i. and ii. is somewhat unclear)

[Matti Rinta-Nikkola (matti-rintanikkola-d)]

I took a new look to the available Suru icons and I found the possible replacements for the icons: starred => stock_website and save => bookmark.

The dialog can be changed from "Set" to "Set the page as".

About "The reset Website Homepage":
The possibility to to reset website homepage is needed because if the page which you have set as a new website homepage has been removed without adding redirection to the valid page it might happen that in your app you cannot access this site anymore (without re-adding the site).
Anyway the reset button can be removed from dialog because the reset can be performed also from "Edit Website" page.

IMHO introducing radio buttons is not a good idea because then you need an additional click to perform the action.

Colour of the buttons???

Let me know what do you think about this plan.

[Peter Bittner (peter-bittner)]

Icons and dialog title: Fine.

Action buttons vs. radio buttons:
- The additional click may not be a disadvantage. Then the user is more aware of their action, because you have to make a deliberate choice, there's no accidental clicking on a button.
- At the moment the buttons are "dangerous". It's not clear where the result of each action is "identical". With a radio button the message is: "The action will be the same for any choice, just select the desired solution." Several primary buttons are irritating.
- The color of the buttons is very meaningful. According to the Ubuntu Touch design guidelines you should probably chose green for "Set page" (by that way a more explicit label than just "OK") and gray for "Cancel".

[Peter Bittner (peter-bittner)]

Buttons on Ubuntu Design: https://design.ubuntu.com/apps/building-blocks/buttons

[Matti Rinta-Nikkola (matti-rintanikkola-d)]

I see, I think then that the choice between action and radio buttons is more like subjective issue than a real problem -I get irritated by the unnecessary clicks.
I will follow the Ubuntu Touch design guidelines and will use action buttons on popup dialogs.
http://design.ubuntu.com/apps/building-blocks/dialog

[Matti Rinta-Nikkola (matti-rintanikkola-d)]

fix commited on revno: 88

[Peter Bittner (peter-bittner)]

Good job, the new icons are very nice!

The bookmarks dialog is also cleaner (though there is no "reset" functionality anymore, is this intentional?). I still don't understand what the "website homepage" is. (The "app homepage" is the start screen when I start the app afresh, I get that.)
The wording is still a bit bumpy: "Set the page as ... app / website homepage" works, but for bookmarks a "Bookmark current page" is probably better suited.

[Matti Rinta-Nikkola (matti-rintanikkola-d)]

I have answered to your question here:
https://answers.launchpad.net/my-webapp-group/+question/271390