hz-magic-search-bar doesn't use a class
Bug #1492422 reported by
Kevin Fox
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Dashboard (Horizon) |
Fix Released
|
Low
|
Kevin Fox |
Bug Description
The css for the magic search bar doesn't use a class but hard codes the element name. This means it can not be reused for the app-catalog-ui. We will have to fork the whole file into the app-catalog-ui, or just change the css file to use a class in horizon so we can share.
Changed in horizon: | |
assignee: | nobody → Kevin Fox (kevpn) |
status: | New → In Progress |
Changed in horizon: | |
importance: | Undecided → Low |
milestone: | none → liberty-rc1 |
Changed in horizon: | |
status: | Fix Committed → Fix Released |
Changed in horizon: | |
milestone: | liberty-rc1 → 8.0.0 |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/220603 /git.openstack. org/cgit/ openstack/ horizon/ commit/ ?id=895efd803c2 2bde5594d6207c4 1f8982e2f6a469
Committed: https:/
Submitter: Jenkins
Branch: master
commit 895efd803c22bde 5594d6207c41f89 82e2f6a469
Author: Kevin Fox <email address hidden>
Date: Fri Sep 4 10:48:50 2015 -0700
Magic Search CSS reuse
The App Catalog UI plugin is using Magic Search but is switching
away from using hz-magic-search-bar directly since it only
supports st-tables and the App Catalog UI supports a grid view
widget. This change allows the hz-magic-search css to be reused
by tagging elements with hz-magic-search-bar class instead of
the css expecting a hz-magic-search-bar element.
Closes-Bug: #1492422 cead568ebdb3d8f f41c7a5db17
Change-Id: I2ba937540f0bbf