build with git clone by reference stable/kilo fails

Bug #1492279 reported by Vladislav Belogrudov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla
Fix Released
Medium
Vladislav Belogrudov

Bug Description

If we specify reference for git clone that includes '/' like in stable/kilo we get failure during archive preparation

Changed in kolla:
importance: Undecided → Medium
assignee: nobody → Vladislav Belogrudov (vlad-belogrudov)
milestone: none → liberty-rc1
Revision history for this message
Vladislav Belogrudov (vlad-belogrudov) wrote :

actually it does not fail any longer after https://review.openstack.org/#/c/219723/
But it does incorrectly name source folder - in case of cinder stable/kilo we get archive root 'kilo'
It would be better to have cinder-stable-kilo, i.e. replace / in names with something else ('-')

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (master)

Fix proposed to branch: master
Review: https://review.openstack.org/220542

Changed in kolla:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (master)

Reviewed: https://review.openstack.org/220542
Committed: https://git.openstack.org/cgit/stackforge/kolla/commit/?id=34cbe82e6efed5222a2ab2b29368505ea8f41f00
Submitter: Jenkins
Branch: master

commit 34cbe82e6efed5222a2ab2b29368505ea8f41f00
Author: Vladislav Belogrudov <email address hidden>
Date: Fri Sep 4 17:47:35 2015 +0300

    Correct name of source archive if reference contains '/'

    If we have reference like stable/kilo name of source archive
    will contain only last part of reference. We should replace '/'
    with '-' to have full name. This is useful for correct
    identification of source code afterwards.

    Change-Id: I1ff1015e3f7926110d0fcb59504e58a5e80a75f9
    Closes-Bug: #1492279

Changed in kolla:
status: In Progress → Fix Committed
Sam Yaple (s8m)
Changed in kolla:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.