VMware: Volume creation fails with 'The operation is not allowed in the current state.'

[Vipin Balachandran]

Steps to reproduce:

a) Configure the VMDK driver with a vCenter with at least 2 ESX hosts

b) Put the ESX host with the smallest ID in maintenance mode.
The ID is part of the host's managed object reference following 'host-'.

c) Create volume

Volume creation will fail with 'VMwareDriverException: The operation is not allowed in the current state.'

Expected behavior:
Volume should be created in a ESX host which is not in maintenance mode.

Work-around:
Move the ESX host in maintenance mode to a separate cluster and configure the VMDK driver to place volumes in the cluster with usable hosts (using vmware_cluster_name option).

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/220461

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/220461
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=ea987d3aba36177b0705c8a8c88365ebf4b40c17
Submitter: Jenkins
Branch: master

commit ea987d3aba36177b0705c8a8c88365ebf4b40c17
Author: Vipin Balachandran <email address hidden>
Date: Wed Aug 26 17:00:40 2015 +0530

    VMware: Skip ESX hosts in maintenance mode

    Volume creation will fail if the VMDK driver selects
    an ESX host in maintenance mode for volume creation.
    This may happen even if there are usable ESX hosts
    in vCenter. This patch fixes the problem by ignoring
    ESX hosts in maintenance mode during volume creation.

    Closes-bug: #1492221
    Change-Id: I8cb89f95d0411ea2140e3107941d4e5e04a0156d