All preview comments are created at the same time
Bug #1492214 reported by
Albert Astals Cid
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical System Image |
Fix Released
|
High
|
kevin gunn | ||
| unity8 (Ubuntu) |
Fix Released
|
High
|
Albert Astals Cid | ||
Bug Description
All the preview comments are created at the same time which can produce considerable delays when the creation happens.
How to reproduce:
* Be on the apps scope
* Long press on telegram to get to the preview
* Scroll down until the place comments have to appear
* Notice the 3 or 4 seconds delay while all the comments are being created
One solution is to use a listview + displayMargin settings so that only the items actually in viewport + a few more for precaching are created and not the whole lot.
Related branches
lp:~aacid/unity8/listviewforreviews
- Michael Zanetti (community): Approve
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
-
Diff: 293 lines (+179/-25)8 files modifiedqml/Dash/Previews/Preview.qml (+2/-0)
qml/Dash/Previews/PreviewRatingDisplay.qml (+72/-21)
qml/Dash/Previews/PreviewWidget.qml (+3/-0)
qml/Dash/Previews/PreviewWidgetFactory.qml (+4/-0)
tests/qmltests/CMakeLists.txt (+1/-0)
tests/qmltests/Dash/Previews/tst_PreviewRatingDisplay.qml (+1/-3)
tests/qmltests/Dash/Previews/tst_PreviewRatingDisplayCreationRanges.qml (+94/-0)
tests/utils/modules/Unity/Test/UnityTestCase.qml (+2/-1)
| Changed in unity8 (Ubuntu): | |
| assignee: | nobody → Albert Astals Cid (aacid) |
| Changed in unity8 (Ubuntu): | |
| status: | New → In Progress |
| Changed in unity8 (Ubuntu): | |
| importance: | Undecided → High |
| Changed in canonical-devices-system-image: | |
| status: | New → Fix Committed |
| importance: | Undecided → High |
| assignee: | nobody → kevin gunn (kgunn72) |
| milestone: | none → ww02-2016 |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in unity8 (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in canonical-devices-system-image: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This bug was fixed in the package unity8 - 8.11+16.
---------------
unity8 (8.11+16.
[ Albert Astals Cid ]
* Allow dragging launcher items with the quicklist open (LP: #1250861)
* Create ratings on demand instead of all at the same time (LP:
#1519898, #1492214)
* LVWPH: Process correctly section changes (LP: #1519893)
* Make sure that unfavoriting a scope gives us the next one
* Move images only used in tests to tests folder
[ Andrea Cimitan ]
* Add shadows to ubuntu store icon
[ Daniel d'Andrada ]
* MirSurfaceItem got a new property: fillMode (LP: #1497083)
* Session can have multiple surfaces now
* plugins/Cursor: Do not force loading a specific cursor size (LP:
#1517878)
[ Lukáš Tinkl ]
* Indicators convergence: use the "phone" profile everywhere (LP:
#1520492)
[ Michael Terry ]
* Let qtmir know which apps are exempt from the lifecycle management.
This way, it can manage its own wakelocks better (and stop
preventing the system from deep sleeping).
[ Michael Zanetti ]
* Use proper z ordering instead of app index for occlusion detection
* add some debug prints to the uinput backend
* drop the ignoredMice hack again (LP: #1521580)
[ Michał Sawicz ]
* Let qtmir know which apps are exempt from the lifecycle management.
This way, it can manage its own wakelocks better (and stop
preventing the system from deep sleeping).
* Update .pot file in debian/clean when in train
-- Gerry Boland <email address hidden> Tue, 08 Dec 2015 15:37:58 +0000