manila devstack plugin no more compatible

[Valeriy Ponomaryov]

Our devstack plugin started hitting following incompatibility issue:

http://logs.openstack.org/88/219788/7/gate/gate-manila-tempest-dsvm-neutron/1a8911d/logs/devstacklog.txt.gz#_2015-09-04_04_10_50_336

or raw:

2015-09-04 04:10:50.336 | +++ openstack service create --type=share '--description=Manila Shared Filesystem Service' manila -f value -c id
2015-09-04 04:10:51.062 | usage: openstack service create [-h] [-f {html,json,shell,table,value,yaml}]
2015-09-04 04:10:51.062 | [-c COLUMN] [--max-width <integer>]
2015-09-04 04:10:51.062 | [--prefix PREFIX] [--name <name>]
2015-09-04 04:10:51.062 | [--description <description>]
2015-09-04 04:10:51.062 | [--enable | --disable]
2015-09-04 04:10:51.062 | <type>
2015-09-04 04:10:51.062 | openstack service create: error: unrecognized arguments: --type=share

So, Manila can not be installed using Devstack, and hence, CI testing is broken for Manila.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/220415

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/220415
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=becb2dd9d000169d719386e882b96a34003cec2b
Submitter: Jenkins
Branch: master

commit becb2dd9d000169d719386e882b96a34003cec2b
Author: Valeriy Ponomaryov <email address hidden>
Date: Fri Sep 4 09:55:13 2015 +0300

    Use devstack functions for registering Manila

    Use devstack functions for registration of Manila to avoid
    incompatibilities in service registering approach. Also, we should
    reuse already defined functions that minimizes our code removing
    duplication.

    Change-Id: Id6e56426b212435366a36122dbeddc52910d9828
    Closes-Bug: #1492133

[Matt Riedemann (mriedem)]

http://logstash.openstack.org/#eyJzZWFyY2giOiJtZXNzYWdlOlwib3BlbnN0YWNrIHNlcnZpY2UgY3JlYXRlOiBlcnJvcjogdW5yZWNvZ25pemVkIGFyZ3VtZW50czogLS10eXBlPXNoYXJlXCIgQU5EIHRhZ3M6XCJjb25zb2xlXCIgQU5EIGJ1aWxkX25hbWU6Z2F0ZS1tYW5pbGEtdGVtcGVzdC1kc3ZtKiIsImZpZWxkcyI6W10sIm9mZnNldCI6MCwidGltZWZyYW1lIjoiNjA0ODAwIiwiZ3JhcGhtb2RlIjoiY291bnQiLCJ0aW1lIjp7InVzZXJfaW50ZXJ2YWwiOjB9LCJzdGFtcCI6MTQ0MTQwMDcwMzY0NiwibW9kZSI6IiIsImFuYWx5emVfZmllbGQiOiIifQ==