OpenStack Dashboard (Horizon)

Create instance testcase -- "test_launch_form_keystone_exception" broken

Bug #1492065 reported by Saksham Varma
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Saksham Varma
OpenStack Dashboard (Horizon) 8.0.0 "liberty"
Kilo
Fix Released
Undecided
Unassigned
OpenStack Dashboard (Horizon) 2015.1.2

Bug Description

The test_launch_form_keystone_exception test method calls the handle method of the LaunchInstance class. Changes made to the handle method in [1] introduced a new neutron api call that was not being mocked out, causing an unexpected exception in the _cleanup_ports_on_failed_vm_launch function of the create_instance module, while running the test_launch_form_keystone_exception unit test

[1] https://review.openstack.org/#/c/202347/

Saksham Varma (sakvarma)
Changed in horizon:
assignee: nobody → Saksham Varma (sakvarma)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/220353

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/220353
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=34ab52966d2bc7550fc2a8de04ad27267ce33f36
Submitter: Jenkins
Branch: master

commit 34ab52966d2bc7550fc2a8de04ad27267ce33f36
Author: Saksham Varma <email address hidden>
Date: Thu Sep 3 16:36:37 2015 -0700

    Fix a unit test for create instance

    The test_launch_form_keystone_exception test method calls the
    handle method of the LaunchInstance class. Changes made to
    the handle method in [1] introduced a new neutron api call
    that was not being mocked out, causing an unexpected exception
    in the _cleanup_ports_on_failed_vm_launch function of the
    create_instance module, while running the
    test_launch_form_keystone_exception unit test

    [1] https://review.openstack.org/#/c/202347/

    Closes-Bug: 1492065
    Change-Id: Ib3ad9146339a60b8d53e849091abf6a9bb64de93

Changed in horizon:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/221438

Rob Cresswell (robcresswell-deactivatedaccount)
Changed in horizon:
importance: Undecided → Medium
milestone: none → liberty-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/kilo)

Reviewed: https://review.openstack.org/221438
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=d6be3061cd36fbf50d973329da742c6080a4b7e2
Submitter: Jenkins
Branch: stable/kilo

commit d6be3061cd36fbf50d973329da742c6080a4b7e2
Author: Saksham Varma <email address hidden>
Date: Thu Sep 3 16:36:37 2015 -0700

    Fix a unit test for create instance

    The test_launch_form_keystone_exception test method calls the
    handle method of the LaunchInstance class. Changes made to
    the handle method in [1] introduced a new neutron api call
    that was not being mocked out, causing an unexpected exception
    in the _cleanup_ports_on_failed_vm_launch function of the
    create_instance module, while running the
    test_launch_form_keystone_exception unit test

    [1] https://review.openstack.org/#/c/202347/

    Closes-Bug: 1492065
    Change-Id: Ib3ad9146339a60b8d53e849091abf6a9bb64de93
    (cherry picked from commit 34ab52966d2bc7550fc2a8de04ad27267ce33f36)

tags: added: in-stable-kilo
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: liberty-rc1 → 8.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.