latch results posting can DOS future lp API reads
Bug #1492029 reported by
David Britton
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| latch |
Fix Released
|
High
|
David Britton | ||
Bug Description
Example: https:/
Scenerio:
* We get a 503 from LP
* latch ignores the collection read error, in order to not block on weird LP errors
* the error is not trickled up, so latch thinks no tests have been done
* so latch kicks off another test, leading to future failed reads.
Two fixes need to be done:
1) Don't treat failed LP reads (503 or otherwise) the same as an empty set read
2) Don't post such big messages, people can just click the results link that latch sticks in there.
Related branches
lp:~dpb/latch-test/dont-be-so-verbose
- Alberto Donato (community): Approve
- Free Ekanayaka (community): Approve
- 🤖 Landscape Builder: Approve (test results)
-
Diff: 360 lines (+173/-45)2 files modifiedlatch.py (+54/-24)
test_latch.py (+119/-21)
| Changed in latch-test: | |
| assignee: | nobody → David Britton (davidpbritton) |
| importance: | Undecided → Medium |
| importance: | Medium → High |
| status: | New → In Progress |
| Changed in latch-test: | |
| status: | In Progress → Fix Committed |
| Changed in latch-test: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
