Manila retry function does not accept random periods

Bug #1491550 reported by Alyson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Medium
Alyson

Bug Description

The current manila.utils.retry() function always uses fixed numbers to define the time to wait before performing the next attempts. This behavior can make the retries of multiple requisitions coincide many times and cause concurrency errors repeatedly.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/219851

Changed in manila:
assignee: nobody → Alyson (alyson-rodrigues-rosa)
status: New → In Progress
Changed in manila:
importance: Undecided → Medium
milestone: none → liberty-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/219851
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=8dc3863e102828ce8bf3111d24ad74acd2dfd405
Submitter: Jenkins
Branch: master

commit 8dc3863e102828ce8bf3111d24ad74acd2dfd405
Author: Alyson Rosa <email address hidden>
Date: Wed Sep 2 13:28:30 2015 -0300

    Adds retry function to HNAS driver

    Multiple requests sent to HNAS can cause concurrency problems
    and that ends up with 'SSC failed connection' errors. This
    patch adds a retry decorator to _execute in HDS HNAS Manila
    driver to fix this problem.

    The current retry functionality in Manila always uses fixed
    numbers to define the time to wait before performing the next
    attempts. This behavior can make the retries of multiple
    requests to collide in each attempt as they will wait the
    same amount of time and try to use the same resource together
    again. So additionally, this patch changes the behavior of
    manila.utils.retry() to receive a parameter that allows the
    function to implement randomly generated wait intervals.

    Change-Id: Ib862f62517fcc8816781204b902119e9b20121e0
    Closes-bug: 1491550

Changed in manila:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in manila:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in manila:
milestone: liberty-rc1 → 1.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.