lost import of translation func in snapshots API

Bug #1491346 reported by Valeriy Ponomaryov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
High
Valeriy Ponomaryov

Bug Description

If we try to delete share that does not have snapshot support we reach code that faces NameError - attempt to use not imported translation func.

See: https://github.com/openstack/manila/blob/af6814f9/manila/api/v1/share_snapshots.py#L155

Tags: api
Changed in manila:
importance: Undecided → High
assignee: nobody → Valeriy Ponomaryov (vponomaryov)
milestone: none → liberty-rc1
tags: added: api
Changed in manila:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/221231
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=3ea5752570564c21d3d0b9386ed2eb23b502a0d2
Submitter: Jenkins
Branch: master

commit 3ea5752570564c21d3d0b9386ed2eb23b502a0d2
Author: Valeriy Ponomaryov <email address hidden>
Date: Tue Sep 8 12:59:41 2015 +0300

    Add 'snapshot_support' attr to share details

    Recently was introduced feature where snapshots become optional.

    Share started have new attr "snapshot_support". But it is absent in
    share payload and, hence, can not be used outside of Manila.

    Also, fix lost import of translation function for related snapshot API.

    Change-Id: Iddb0cf1e046b9d480a22e79b33c8674a2405362e
    Closes-Bug: #1491345
    Closes-Bug: #1491346

Changed in manila:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in manila:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in manila:
milestone: liberty-rc1 → 1.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.