[OSTF] Need to refactor cloudvalidation test

Bug #1491294 reported by Alexander Gubanov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Invalid
Medium
Fuel QA Team

Bug Description

1. We need to remove excess "cat" and "tail" commands in cloudvalidation/test_disk_space_db.py [1], because "grep" already has this functionality.
Also, we should use "fgrep" to disable mechanism of regular expression - on big search will complete faster.

2. "Ugly" output if test failed:

Free disk space cannot be used by database on node(s): [u'10.177.30.6', u'10.177.30.5'].
Please refer to OpenStack logs for more details.

[1]: https://github.com/stackforge/fuel-ostf/blob/master/fuel_health/tests/cloudvalidation/test_disk_space_db.py#L34-L35

Tags: area-qa
Changed in fuel:
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Fuel QA Team (fuel-qa)
tags: added: module-ostf
removed: ostf
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-ostf (master)

Fix proposed to branch: master
Review: https://review.openstack.org/237956

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-ostf (master)

Reviewed: https://review.openstack.org/237956
Committed: https://git.openstack.org/cgit/openstack/fuel-ostf/commit/?id=9f500668555292add5d87c942e0cd804aefa6df2
Submitter: Jenkins
Branch: master

commit 9f500668555292add5d87c942e0cd804aefa6df2
Author: Tatyana Leontovich <email address hidden>
Date: Wed Oct 21 12:40:23 2015 +0300

    Replace cat usage for fgrep

    Replace "cat" command to "fgrep" in test test_disk_space_db

    Change-Id: Ia6bd197f3b7448df7834a3cc9384661c1eccc9df
    Closes-Bug: #1491294

Changed in fuel:
status: In Progress → Fix Committed
Dmitry Pyzhov (dpyzhov)
tags: added: area-qa
Revision history for this message
Alexander Gubanov (ogubanov) wrote :

Patch doesn't fix all issues described above, I mean:
>2. "Ugly" output if test failed:

Changed in fuel:
status: Fix Committed → Confirmed
Revision history for this message
Tatyanka (tatyana-leontovich) wrote :

This tests disabled and is not executed - so it can be failed at all

Changed in fuel:
status: Confirmed → Invalid
Revision history for this message
Tatyanka (tatyana-leontovich) wrote :

So move to invalid

Revision history for this message
Tatyanka (tatyana-leontovich) wrote :
tags: removed: area-qa module-ostf
Dmitry Pyzhov (dpyzhov)
tags: added: area-qa
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.