barbican client doesn't use keystone correctly

Bug #1491257 reported by yuanying
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum
Fix Released
High
yuanying

Bug Description

In magnum.common.clients, barbican client uses `keystone()._client`
directly, but `keystone().client` is better to use.

Because..

* `keystone()._client` is None if it was not loaded.
* `keystone().client` can return keystone client which has admin privilege.

yuanying (yuanying)
Changed in magnum:
assignee: nobody → yuanying (ootsuka)
importance: Undecided → Medium
importance: Medium → High
Changed in magnum:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/219579
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=77d1e32c9465d63965109a3cbefc93f6aaf54052
Submitter: Jenkins
Branch: master

commit 77d1e32c9465d63965109a3cbefc93f6aaf54052
Author: OTSUKA, Yuanying <email address hidden>
Date: Wed Sep 2 13:24:45 2015 +0900

    Fix keystone client usage in barbican client

    In magnum.common.clients, barbican client uses
    `keystone()._client` directly, but `keystone().client`
    is better. Because, keystone()._client is None is it
    is not loaded.

    This fixes it.

    Closes-Bug: #1491257
    Change-Id: I3771ebef9c2a1d3756ea4ed2f964751d1c2da43f

Changed in magnum:
status: In Progress → Fix Committed
Adrian Otto (aotto)
Changed in magnum:
milestone: none → mitaka-2
status: Fix Committed → Fix Released
Adrian Otto (aotto)
Changed in magnum:
milestone: mitaka-2 → mitaka-1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.