Don't run shelve tests in tempest if cells is enabled

Bug #1491152 reported by Matt Riedemann
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Chuck Carmack
devstack
Invalid
Undecided
Chuck Carmack

Bug Description

Nova controls the tests it runs (or doesn't run) for the cells devstack tempest job in:

http://git.openstack.org/cgit/openstack/nova/tree/devstack/tempest-dsvm-cells-rc

There are 3 tests in there that are blacklisted for shelve.

Tempest provides a config option to not run the shelve tests:

http://git.openstack.org/cgit/openstack/tempest/tree/tempest/config.py#n343

We should move that out of the nova rc file and into devstack/lib/tempest, like what is done for ironic:

https://github.com/openstack-dev/devstack/blob/master/lib/tempest#L526

So in lib/tempest you'd check to see if the n-cells service is running and if so, initset tempest.conf to not run shelve tests, i.e.:

if is_service_enabled n-cell; then
    iniset $TEMPEST_CONFIG compute-feature-enabled shelve False
fi

Revision history for this message
Matt Riedemann (mriedem) wrote :

Once the change is in devstack we can remove the excluded shelve tests from http://git.openstack.org/cgit/openstack/nova/tree/devstack/tempest-dsvm-cells-rc in nova.

Changed in nova:
status: New → Triaged
Changed in devstack:
status: New → Confirmed
tags: added: low-hanging-fruit
Matt Riedemann (mriedem)
Changed in nova:
assignee: nobody → Chuck Carmack (chuckcarmack75)
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to devstack (master)

Fix proposed to branch: master
Review: https://review.openstack.org/219718

Changed in devstack:
assignee: nobody → Chuck Carmack (chuckcarmack75)
status: Confirmed → In Progress
Matt Riedemann (mriedem)
tags: added: cells testing
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/219778

Changed in nova:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by Chuck Carmack (<email address hidden>) on branch: master
Review: https://review.openstack.org/219778

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/220158

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to devstack (master)

Reviewed: https://review.openstack.org/219718
Committed: https://git.openstack.org/cgit/openstack-dev/devstack/commit/?id=09b431d72d3db29e01be44f85dcbfcb78f651b13
Submitter: Jenkins
Branch: master

commit 09b431d72d3db29e01be44f85dcbfcb78f651b13
Author: Chuck Carmack <email address hidden>
Date: Wed Sep 2 14:27:58 2015 +0000

    Disable the shelve tests for nova-cells using tempest config

    Change from using a blacklist to disable the shelve tests for
    nova-cells to using the tempest config option to disable the shelve
    feature tests. This is the intended method of disabling feature tests.
    This first commit is to add code to lib/tempest to disable the shelve
    feature test if the nova-cells service is enabled. The next
    st will remove the shelve blacklist from
    http://git.openstack.org/cgit/openstack/nova/tree/devstack/tempest-dsvm-cells-rc

    Change-Id: Ibf1f9aaa63e5f17b7d8774b511940ba8421e0887
    Partial-bug: 1491152

Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/220158
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=418584683148f4f31ca8e6262f26f071831c105c
Submitter: Jenkins
Branch: master

commit 418584683148f4f31ca8e6262f26f071831c105c
Author: Chuck Carmack <email address hidden>
Date: Thu Sep 3 14:13:30 2015 +0000

    Remove the blacklisted nova-cells shelve tests

    nova-cells does not support the shelve feature.
    Since the nova-cells shelve tests are now disabled using
    the tempest feature config options, we can remove the
    shelve tests from the blacklist.

    Change-Id: Iad51bfcff49b7eabc46101bd7f956adfa5958ced
    Closes-bug: 1491152
    Depends-On: Ibf1f9aaa63e5f17b7d8774b511940ba8421e0887

Thierry Carrez (ttx)
Changed in nova:
milestone: none → liberty-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: liberty-rc1 → 12.0.0
Revision history for this message
Sean Dague (sdague) wrote :

This devstack bug was last updated over 180 days ago, as devstack
is a fast moving project and we'd like to get the tracker down to
currently actionable bugs, this is getting marked as Invalid. If the
issue still exists, please feel free to reopen it.

Changed in devstack:
status: In Progress → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.