Claims Returned items cannot be renewed when not in a checked out status

[Kathy Lussier]

In https://bugs.launchpad.net/evergreen/+bug/638509, we fixed a bug where renewals on claims returned transactions (among others) would fail with an ugly error message.

The code does indeed fix the problem with renewals under default Evergreen behavior where claims returned items retain a status of checked out.

However, there is a library setting that allows sites to put Claims Returned items into an alternate copy status. If staff try renewing items at those sites, they will continue to get an ugly error message.

I tried two different scenarios. In the case where sites set Claims Returned item to go to the stock status of missing, I received the following error message when trying to renew the item:

[

 {
  "stacktrace":"/usr/local/share/perl/5.14.2/OpenILS/Application/Circ/Circulate.pm:1017 /usr/local/share/perl/5.14.2/OpenILS/Application/Circ/Circulate.pm:3716 /usr/local/share/perl/5.14.2/OpenILS/Application/Circ/Circulate.pm:3668",
  "ilsevent":"7004",
  "pid":"14504",
  "desc":" Copy is not available ",
  "payload":
  {
   "__c":"acp",
   "__p":
   [
    null,
    null,
    "G880400001542",
    1542,
    null,
    4,
    null,
    "t",
    null,
    "2015-08-17T13:08:44-0400",
    "2015-08-17T13:08:44-0400",
    1,
    "f",
    null,
    "f",
    "0.00",
    null,
    null,
    "now",
    1,
    1,
    "t",
    4112,
    1,
    146,
    "t",
    null,
    "f",

    {
     "__c":"ccs",
     "__p":
     [
      "t",
      7,
      "Reshelving",
      "t",
      "t",
      "f"
     ]

    }
    ,
    "2015-09-01T14:38:07-0400",
    "t",
    null,
    null,
    null,
    null,
    null,
    null,
    null,
    null,
    null,
    null,
    null,

    [

    ]

   ]

  }
  ,
  "textcode":"COPY_NOT_AVAILABLE",
  "servertime":"Tue Sep 1 14:38:15 2015"
 }
 ,

 {
  "stacktrace":"/usr/local/share/perl/5.14.2/OpenILS/Application/Circ/Circulate.pm:1017 /usr/local/share/perl/5.14.2/OpenILS/Application/Circ/Circulate.pm:3716 /usr/local/share/perl/5.14.2/OpenILS/Application/Circ/Circulate.pm:3668",
  "ilsevent":"7003",
  "pid":"14504",
  "desc":" Target copy is not allowed to circulate ",
  "payload":
  {
   "fail_part":"asset.copy_location.circulate"
  }
  ,
  "textcode":"COPY_CIRC_NOT_ALLOWED",
  "servertime":"Tue Sep 1 14:38:15 2015"
 }
 ,

 {
  "stacktrace":"/usr/local/share/perl/5.14.2/OpenILS/Application/Circ/Circulate.pm:3518 /usr/local/share/perl/5.14.2/OpenILS/Application/Circ/Circulate.pm:2365 /usr/local/share/perl/5.14.2/OpenILS/Application/Circ/Circulate.pm:3671",
  "ilsevent":"7012",
  "pid":"14504",
  "desc":"Copy is marked as missing",
  "payload":
  {
   "__c":"acp",
   "__p":
   [
    null,
    null,
    "G880400001542",
    1542,
    null,
    4,
    null,
    "t",
    null,
    "2015-08-17T13:08:44-0400",
    "2015-08-17T13:08:44-0400",
    1,
    "f",
    null,
    "f",
    "0.00",
    null,
    null,
    "now",
    1,
    1,
    "t",
    4112,
    1,
    146,
    "t",
    null,
    "f",

    {
     "__c":"ccs",
     "__p":
     [
      "t",
      7,
      "Reshelving",
      "t",
      "t",
      "f"
     ]

    }
    ,
    "2015-09-01T14:38:07-0400",
    "t",
    null,
    null,
    null,
    null,
    null,
    null,
    null,
    null,
    null,
    null,
    null,

    [

    ]

   ]

  }
  ,
  "textcode":"COPY_STATUS_MISSING",
  "servertime":"Tue Sep 1 14:38:15 2015"
 }
 ,

 {
  "stacktrace":"/usr/local/share/perl/5.14.2/OpenILS/Application/Circ/Circulate.pm:2368 /usr/local/share/perl/5.14.2/OpenILS/Application/Circ/Circulate.pm:3671 /usr/local/share/perl/5.14.2/OpenILS/Application/Circ/Circulate.pm:275",
  "ilsevent":"7009",
  "pid":"14504",
  "desc":" Requested circulation is marked claims returned ",
  "textcode":"CIRC_CLAIMS_RETURNED",
  "servertime":"Tue Sep 1 14:38:15 2015"
 }

]

In another instance, I tried to renew a claims returned item in a scenario where a site moves Claims Returned items to a custom status (Claimed Returned). I receive the following error message when trying to renew:

Network or server failure. Please check your Internet connection to mlnc1.mvlcstaff.org and choose Retry Network. If you need to enter Offline Mode, choose Ignore Errors in this and subsequent dialogs. If you believe this error is due to a bug in Evergreen and not network problems, please contact your help desk or friendly Evergreen administrators, and give them this information:
method=open-ils.circ.renew
params=["114bbee1cc553b555a40129fa795ee75",{"barcode":"G880410001542","patron":71}]
THROWN:
{"payload":[],"debug":"osrfMethodException : *** Call to [open-ils.circ.renew] failed for session [1441131408.731512.144113140819752], thread trace [1]:\nCan't call method \"id\" on an undefined value at /usr/local/share/perl/5.14.2/OpenILS/Application/Circ/Circulate.pm line 2187.\n\n","status":500}
STATUS:

[Michele Morgan (mmorgan)]

Confirming that this happens on our 2.9.1 system. We have the org unit setting set to use the custom status "Claimed Returned". I don't see the "Network or server failure" message, but do get an Unhandled error. The debug output is essentially what Kathy posted above. Including it here:

Please open a helpdesk ticket and include the following text:

Wed May 25 2016 11:31:51 GMT-0400 (Eastern Daylight Time)

Renew Failed for 31729001506507

[

{
"stacktrace":"/usr/local/share/perl/5.14.2/OpenILS/Application/Circ/Circulate.pm:3626 /usr/local/share/perl/5.14.2/OpenILS/Application/Circ/Circulate.pm:268 /usr/local/share/perl/5.14.2/OpenSRF/Application.pm:594",
"ilsevent":"7008",
"pid":"16702",
"desc":" Circulation has no more renewals remaining ",
"textcode":"MAX_RENEWALS_REACHED",
"servertime":"Wed May 25 11:27:48 2016"
}
,

{
"stacktrace":"/usr/local/share/perl/5.14.2/OpenILS/Application/Circ/Circulate.pm:1006 /usr/local/share/perl/5.14.2/OpenILS/Application/Circ/Circulate.pm:3716 /usr/local/share/perl/5.14.2/OpenILS/Application/Circ/Circulate.pm:3668",
"ilsevent":"7004",
"pid":"16702",
"desc":" Copy is not available ",
"payload":
{
"__c":"acp",
"__p":
[
null,
"",
"31729001506507",

{
"__c":"acn",
"__p":
[
null,
"2012-05-26T09:19:55-0400",
1,
"f",
"2013-10-21T11:26:47-0400",
1,
2538840,
"Tigger Movie",
68,
1944821,
null,
null,
null,
"TIGGER MOVIE",
1,
1349,
-1
]

}
,
null,
68,
"childrensdvd",
"t",
1,
"2005-05-20T00:00:00-0400",
"2012-05-26T09:19:55-0400",
1,
"f",
null,
"f",
"0.00",
null,
null,
"now",
1,
2,
"t",
5958745,
2,
828,
"t",
"16.99",
"f",

{
"__c":"ccs",
"__p":
[
"t",
7,
"Reshelving",
"t",
"t",
"f"
]

}
,
"2016-05-25T11:27:35-0400",
"t",
null,
null,
null,
null,
null,
null,
null,
null,
null,
null,
null,

[

]

]

}
,
"textcode":"COPY_NOT_AVAILABLE",
"servertime":"Wed May 25 11:27:48 2016"
}
,

{
"stacktrace":"/usr/local/share/perl/5.14.2/OpenILS/Application/Circ/Circulate.pm:3521 /usr/local/share/perl/5.14.2/OpenILS/Application/Circ/Circulate.pm:2353 /usr/local/share/perl/5.14.2/OpenILS/Application/Circ/Circulate.pm:3671",
"ilsevent":"1203",
"pid":"16702",
"desc":"The given copy is not in a standard circulation status",
"payload":
{
"__c":"acp",
"__p":
[
null,
"",
"31729001506507",

{
"__c":"acn",
"__p":
[
null,
"2012-05-26T09:19:55-0400",
1,
"f",
"2013-10-21T11:26:47-0400",
1,
2538840,
"Tigger Movie",
68,
1944821,
null,
null,
null,
"TIGGER MOVIE",
1,
1349,
-1
]

}
,
null,
68,
"childrensdvd",
"t",
1,
"2005-05-20T00:00:00-0400",
"2012-05-26T09:19:55-0400",
1,
"f",
null,
"f",
"0.00",
null,
null,
"now",
1,
2,
"t",
5958745,
2,
828,
"t",
"16.99",
"f",

{
"__c":"ccs",
"__p":
[
"t",
7,
"Reshelving",
"t",
"t",
"f"
]

}
,
"2016-05-25T11:27:35-0400",
"t",
null,
null,
null,
null,
null,
null,
null,
null,
null,
null,
null,

[

]

]

}
,
"textcode":"COPY_BAD_STATUS",
"servertime":"Wed May 25 11:27:48 2016"
}
,

{
"stacktrace":"/usr/local/share/perl/5.14.2/OpenILS/Application/Circ/Circulate.pm:2356 /usr/local/share/perl/5.14.2/OpenILS/Application/Circ/Circulate.pm:3671 /usr/local/share/perl/5.14.2/OpenILS/Application/Circ/Circulate.pm:268",
"ilsevent":"7009",
"pid":"16702",
"desc":" Requested circulation is marked claims returned ",
"textcode":"CIRC_C...